<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>On 9/23/19 2:06 PM, Tim Orling wrote:<br>
</p>
<blockquote type="cite"
cite="mid:CANx9H-A2D-sAhKW7YaXnG0E1wg5odcOWubA=BbqwK85XD6nC7A@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div><br>
</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Sep 23, 2019 at 8:53
AM Trevor Gamblin <<a
href="mailto:Trevor.Gamblin@windriver.com"
moz-do-not-send="true">Trevor.Gamblin@windriver.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">From:
Trevor Gamblin <<a
href="mailto:trevor.gamblin@windriver.com" target="_blank"
moz-do-not-send="true">trevor.gamblin@windriver.com</a>><br>
<br>
Without access to unittest, subunit cannot be imported in
python3:<br>
<br>
root@qemux86-64:~# python3<br>
Python 3.7.4 (default, Sep 20 2019, 13:38:31)<br>
[GCC 9.2.0] on linux<br>
Type "help", "copyright", "credits" or "license" for
more information.<br>
>>> import subunit<br>
Traceback (most recent call last):<br>
File "<stdin>", line 1, in <module><br>
File
"/usr/lib/python3.7/site-packages/subunit/__init__.py", line
123, in <module><br>
import unittest<br>
ModuleNotFoundError: No module named 'unittest'<br>
>>><br>
<br>
Adding python3-testtools to python3-subunit's RDEPENDS fixes
the<br>
issue. This also implicitly provides the functionality found
in<br>
the python3-extras module.<br>
</blockquote>
<div dir="auto"><br>
</div>
<div dir="auto">If we literally only need unittest, then
RDEPENDS on -testtools is overkill. We only need the
-unittest submodule:</div>
<div dir="auto">
<div><a
href="http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/python/python3/python3-manifest.json#n1158"
moz-do-not-send="true">http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/python/python3/python3-manifest.json#n1158</a></div>
</div>
</div>
</div>
</blockquote>
<p>After running a quick test with python3-unittest and
python3-extras as the RDEPENDS:</p>
<p>root@qemux86-64:~#
python3
<br>
Python 3.7.4 (default, Sep 20 2019, 13:38:31) <br>
[GCC 9.2.0] on
linux
<br>
Type "help", "copyright", "credits" or "license" for more
information. <br>
>>> import subunit <br>
Traceback (most recent call
last): <br>
File "<stdin>", line 1, in
<module>
<br>
File "/usr/lib/python3.7/site-packages/subunit/__init__.py",
line 130, in <module> <br>
from testtools import content, content_type,
ExtendedToOriginalDecorator
<br>
ModuleNotFoundError: No module named 'testtools'</p>
<p><br>
</p>
<p>It does require testtools, but the errors being thrown were for
the unittest and extras modules (both included with testtools).<br>
</p>
<blockquote type="cite"
cite="mid:CANx9H-A2D-sAhKW7YaXnG0E1wg5odcOWubA=BbqwK85XD6nC7A@mail.gmail.com">
<div>
<div class="gmail_quote">
<div dir="auto"><br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Signed-off-by: Trevor Gamblin <<a
href="mailto:trevor.gamblin@windriver.com" target="_blank"
moz-do-not-send="true">trevor.gamblin@windriver.com</a>><br>
---<br>
meta/recipes-devtools/python/<a
href="http://python3-subunit_1.3.0.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">python3-subunit_1.3.0.bb</a>
| 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/meta/recipes-devtools/python/<a
href="http://python3-subunit_1.3.0.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">python3-subunit_1.3.0.bb</a>
b/meta/recipes-devtools/python/<a
href="http://python3-subunit_1.3.0.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">python3-subunit_1.3.0.bb</a><br>
index 2ece4451df..55066e2d0f 100644<br>
--- a/meta/recipes-devtools/python/<a
href="http://python3-subunit_1.3.0.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">python3-subunit_1.3.0.bb</a><br>
+++ b/meta/recipes-devtools/python/<a
href="http://python3-subunit_1.3.0.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">python3-subunit_1.3.0.bb</a><br>
@@ -1,2 +1,4 @@<br>
inherit setuptools3<br>
require python-subunit.inc<br>
+<br>
+RDEPENDS_${PN} = " python3-testtools"<br>
-- <br>
2.21.0<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org"
target="_blank" moz-do-not-send="true">Openembedded-core@lists.openembedded.org</a><br>
<a
href="http://lists.openembedded.org/mailman/listinfo/openembedded-core"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>
</div>
</div>
</blockquote>
</body>
</html>