<div dir="ltr"><div>Thanks for the review!</div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 7, 2019 at 2:12 PM Randy MacLeod <<a href="mailto:randy.macleod@windriver.com">randy.macleod@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/2/19 4:52 PM, Maxime Roussin-Bélanger wrote:<br>
> Signed-off-by: Maxime Roussin-Bélanger <<a href="mailto:maxime.roussinbelanger@gmail.com" target="_blank">maxime.roussinbelanger@gmail.com</a>><br>
> ---<br>
> meta/recipes-devtools/apt/apt.inc | 3 +++<br>
> meta/recipes-devtools/cmake/cmake.inc | 6 ++++++<br>
> meta/recipes-devtools/dejagnu/<a href="http://dejagnu_1.6.2.bb" rel="noreferrer" target="_blank">dejagnu_1.6.2.bb</a> | 2 ++<br>
> meta/recipes-devtools/dnf/<a href="http://dnf_4.2.2.bb" rel="noreferrer" target="_blank">dnf_4.2.2.bb</a> | 5 ++++-<br>
> meta/recipes-devtools/meson/meson.inc | 3 +++<br>
> meta/recipes-devtools/qemu/qemu.inc | 4 ++++<br>
> meta/recipes-devtools/quilt/quilt.inc | 4 ++++<br>
> meta/recipes-devtools/swig/swig.inc | 3 +++<br>
> meta/recipes-devtools/unfs3/<a href="http://unfs3_git.bb" rel="noreferrer" target="_blank">unfs3_git.bb</a> | 3 +++<br>
> 9 files changed, 32 insertions(+), 1 deletion(-)<br>
<br>
Thanks for the updates Maxime. I have a few minor fixes/questions.<br>
> <br>
> diff --git a/meta/recipes-devtools/apt/apt.inc b/meta/recipes-devtools/apt/apt.inc<br>
> index b855099e52..6883ac865a 100644<br>
> --- a/meta/recipes-devtools/apt/apt.inc<br>
> +++ b/meta/recipes-devtools/apt/apt.inc<br>
> @@ -1,4 +1,7 @@<br>
> SUMMARY = "Advanced front-end for dpkg"<br>
> +DESCRIPTION = "Provides commandline tools for searching and managing as well \<br>
s/commandline/command-line/<br>
according to:<br>
<a href="https://en.wikipedia.org/wiki/Command-line_interface" rel="noreferrer" target="_blank">https://en.wikipedia.org/wiki/Command-line_interface</a><br>
<a href="https://wiki.debian.org/Apt" rel="noreferrer" target="_blank">https://wiki.debian.org/Apt</a><br>
<br>
> +as querying information about packages as a low-level access to all features \<br>
> +of the libapt-pkg library."<br>
> LICENSE = "GPLv2.0+"<br>
> SECTION = "base"<br>
> <br>
> diff --git a/meta/recipes-devtools/cmake/cmake.inc b/meta/recipes-devtools/cmake/cmake.inc<br>
> index 3711f18db6..35d78eea17 100644<br>
> --- a/meta/recipes-devtools/cmake/cmake.inc<br>
> +++ b/meta/recipes-devtools/cmake/cmake.inc<br>
> @@ -2,6 +2,12 @@<br>
> # Released under the MIT license (see packages/COPYING)<br>
> <br>
> SUMMARY = "Cross-platform, open-source make system"<br>
> +DESCRIPTION = "CMake is used to control the software compilation process \<br>
> +using simple platform and compiler independent configuration files. CMake \<br>
> +generates native makefiles and workspaces that can be used in the compiler \<br>
> +environment of your choice. <br>
Should we cut off the text here?<br></blockquote><div><br></div><div>Probably... after rereading I feel this is extra text and it doesn't add much.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> CMake is quite sophisticated: it is possible to \<br>
> +support complex environments requiring system configuration, pre-processor \<br>
> +generation, code generation, and template instantiation."<br>
> HOMEPAGE = "<a href="http://www.cmake.org/" rel="noreferrer" target="_blank">http://www.cmake.org/</a>"<br>
> BUGTRACKER = "<a href="http://public.kitware.com/Bug/my_view_page.php" rel="noreferrer" target="_blank">http://public.kitware.com/Bug/my_view_page.php</a>"<br>
> SECTION = "console/utils"<br>
> diff --git a/meta/recipes-devtools/dejagnu/<a href="http://dejagnu_1.6.2.bb" rel="noreferrer" target="_blank">dejagnu_1.6.2.bb</a> b/meta/recipes-devtools/dejagnu/<a href="http://dejagnu_1.6.2.bb" rel="noreferrer" target="_blank">dejagnu_1.6.2.bb</a><br>
> index 7dc4e417f6..10220ebc91 100644<br>
> --- a/meta/recipes-devtools/dejagnu/<a href="http://dejagnu_1.6.2.bb" rel="noreferrer" target="_blank">dejagnu_1.6.2.bb</a><br>
> +++ b/meta/recipes-devtools/dejagnu/<a href="http://dejagnu_1.6.2.bb" rel="noreferrer" target="_blank">dejagnu_1.6.2.bb</a><br>
> @@ -1,4 +1,6 @@<br>
> SUMMARY = "GNU unit testing framework, written in Expect and Tcl"<br>
> +DESCRIPTION = "DejaGnu is a framework for testing other programs. Its purpose \<br>
> +is to provide a single front end for all tests."<br>
> LICENSE = "GPLv2"<br>
> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"<br>
> SECTION = "devel"<br>
> diff --git a/meta/recipes-devtools/dnf/<a href="http://dnf_4.2.2.bb" rel="noreferrer" target="_blank">dnf_4.2.2.bb</a> b/meta/recipes-devtools/dnf/<a href="http://dnf_4.2.2.bb" rel="noreferrer" target="_blank">dnf_4.2.2.bb</a><br>
> index c77773332c..f38167f1ad 100644<br>
> --- a/meta/recipes-devtools/dnf/<a href="http://dnf_4.2.2.bb" rel="noreferrer" target="_blank">dnf_4.2.2.bb</a><br>
> +++ b/meta/recipes-devtools/dnf/<a href="http://dnf_4.2.2.bb" rel="noreferrer" target="_blank">dnf_4.2.2.bb</a><br>
> @@ -1,4 +1,7 @@<br>
> SUMMARY = "Package manager forked from Yum, using libsolv as a dependency resolver"<br>
> +DESCRIPTION = "Software package manager that installs, updates, and removes \<br>
> +packages on RPM-based Linux distributions. It automatically computes \<br>
> +dependencies and determines the actions required to install packages."<br>
> LICENSE = "GPLv2"<br>
> LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \<br>
> file://PACKAGE-LICENSING;md5=4a0548e303dbc77f067335b4d688e745 \<br>
> @@ -71,7 +74,7 @@ do_install_append_class-native() {<br>
> do_install_append_class-nativesdk() {<br>
> create_wrapper ${D}/${bindir}/dnf \<br>
> RPM_CONFIGDIR=${SDKPATHNATIVE}${libdir_nativesdk}/rpm \<br>
> - RPM_NO_CHROOT_FOR_SCRIPTS=1<br>
> + RPM_NO_CHROOT_FOR_SCRIPTS=1<br>
Whitespace only? Ah, you removed a trailing space.<br>
Please add:<br>
Remove trailing space in dnf recipe.<br>
in the log to prevent OCDers from wondering if there was a typo.<br></blockquote><div><br></div><div>I was not intending to submit this change.</div><div><br></div><div>Your comment means to submit a 2 part patch with this change right?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> }<br>
> <br>
> SYSTEMD_SERVICE_${PN} = "dnf-makecache.service dnf-makecache.timer \<br>
> diff --git a/meta/recipes-devtools/meson/meson.inc b/meta/recipes-devtools/meson/meson.inc<br>
> index 6de109de7f..2958a2a8de 100644<br>
> --- a/meta/recipes-devtools/meson/meson.inc<br>
> +++ b/meta/recipes-devtools/meson/meson.inc<br>
> @@ -1,5 +1,8 @@<br>
> HOMEPAGE = "<a href="http://mesonbuild.com" rel="noreferrer" target="_blank">http://mesonbuild.com</a>"<br>
> SUMMARY = "A high performance build system"<br>
> +DESCRIPTION = "Meson is a build system designed to increase programmer \<br>
> +productivity. It does this by providing a fast, simple and easy to use \<br>
> +interface for modern software development tools and practices."<br>
> <br>
> LICENSE = "Apache-2.0"<br>
> LIC_FILES_CHKSUM = "file://COPYING;md5=3b83ef96387f14655fc854ddc3c6bd57"<br>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc<br>
> index de21d30732..11783eaca5 100644<br>
> --- a/meta/recipes-devtools/qemu/qemu.inc<br>
> +++ b/meta/recipes-devtools/qemu/qemu.inc<br>
> @@ -1,4 +1,8 @@<br>
> SUMMARY = "Fast open source processor emulator"<br>
> +DESCRIPTION = "QEMU is a hosted virtual machine monitor: it emulates the \<br>
> +machine's processor through dynamic binary translation and provides a set \<br>
> +of different hardware and device models for the machine, enabling it to run \<br>
> +a variety of guest operating systems"<br>
> HOMEPAGE = "<a href="http://qemu.org" rel="noreferrer" target="_blank">http://qemu.org</a>"<br>
> LICENSE = "GPLv2 & LGPLv2.1"<br>
> <br>
> diff --git a/meta/recipes-devtools/quilt/quilt.inc b/meta/recipes-devtools/quilt/quilt.inc<br>
> index 433e9b40b7..61e1c93605 100644<br>
> --- a/meta/recipes-devtools/quilt/quilt.inc<br>
> +++ b/meta/recipes-devtools/quilt/quilt.inc<br>
> @@ -1,4 +1,8 @@<br>
> SUMMARY = "Tool for working with series of patches"<br>
> +DESCRIPTION = "Quilt is a tool to manage large sets of patches by keeping \<br>
> +track of the changes each patch makes. Patches can be applied, un-applied,\<br>
> +refreshed, etc. <br>
End here as is done:<br>
<a href="http://savannah.nongnu.org/projects/quilt/" rel="noreferrer" target="_blank">http://savannah.nongnu.org/projects/quilt/</a><br>
> The key philosophical concept is that your primary output \<br>
> +is patches." </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks again for the updates.<br>
../Randy<br>
<br>
> HOMEPAGE = "<a href="http://savannah.nongnu.org/projects/quilt/" rel="noreferrer" target="_blank">http://savannah.nongnu.org/projects/quilt/</a>"<br>
> SECTION = "devel"<br>
> LICENSE = "GPLv2"<br>
> diff --git a/meta/recipes-devtools/swig/swig.inc b/meta/recipes-devtools/swig/swig.inc<br>
> index 00b9c5b605..e62718c508 100644<br>
> --- a/meta/recipes-devtools/swig/swig.inc<br>
> +++ b/meta/recipes-devtools/swig/swig.inc<br>
> @@ -1,4 +1,7 @@<br>
> SUMMARY = "SWIG - Simplified Wrapper and Interface Generator"<br>
> +DESCRIPTION = "SWIG is a compiler that makes it easy to integrate C and C++ \<br>
> +code with other languages including Perl, Tcl, Ruby, Python, Java, Guile, \<br>
> +Mzscheme, Chicken, OCaml, Pike, and C#."<br>
> HOMEPAGE = "<a href="http://swig.sourceforge.net/" rel="noreferrer" target="_blank">http://swig.sourceforge.net/</a>"<br>
> LICENSE = "BSD & GPLv3"<br>
> LIC_FILES_CHKSUM = "file://LICENSE;md5=e7807a6282784a7dde4c846626b08fc6 \<br>
> diff --git a/meta/recipes-devtools/unfs3/<a href="http://unfs3_git.bb" rel="noreferrer" target="_blank">unfs3_git.bb</a> b/meta/recipes-devtools/unfs3/<a href="http://unfs3_git.bb" rel="noreferrer" target="_blank">unfs3_git.bb</a><br>
> index a4ac46c68e..79d09788d3 100644<br>
> --- a/meta/recipes-devtools/unfs3/<a href="http://unfs3_git.bb" rel="noreferrer" target="_blank">unfs3_git.bb</a><br>
> +++ b/meta/recipes-devtools/unfs3/<a href="http://unfs3_git.bb" rel="noreferrer" target="_blank">unfs3_git.bb</a><br>
> @@ -1,4 +1,7 @@<br>
> SUMMARY = "Userspace NFS server v3 protocol"<br>
> +DESCRIPTION = "UNFS3 is a user-space implementation of the NFSv3 server \<br>
> +specification. It provides a daemon for the MOUNT and NFS protocols, which \<br>
> +are used by NFS clients for accessing files on the server."<br>
> SECTION = "console/network"<br>
> LICENSE = "unfs3"<br>
> LIC_FILES_CHKSUM = "file://LICENSE;md5=9475885294e17c0cc0067820d042792e"<br>
> <br>
<br>
<br>
-- <br>
# Randy MacLeod<br>
# Wind River Linux<br>
</blockquote></div></div>