<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 21, 2019 at 4:35 PM Mark Hatle <<a href="mailto:mark.hatle@kernel.crashing.org">mark.hatle@kernel.crashing.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/21/19 4:43 AM, Yann CARDAILLAC wrote:<br>
> Hi Mark Hatle, Jakub Jelinek,<br>
<br>
Jakub is no longer supporting this code, but he may have valuable insights into<br>
licensing.<br>
<br>
> I'm currently beginning the work on bug 13529:<br>
> <br>
> <a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=13529" rel="noreferrer" target="_blank">https://bugzilla.yoctoproject.org/show_bug.cgi?id=13529</a><br>
> <br>
> The purpose is to add SPDX identifier to scripts and sources.<br>
> <br>
> Most of the sources have licences on the sources, however some of them don't,<br>
> and I've question about others :<br>
> <br>
> - src/sha.c do not shall it be GPLV2-or-later as most of the other?<br>
<br>
/* sha.c - Functions to compute the SHA1 hash (message-digest) of files<br>
or blocks of memory. Complies to the NIST specification FIPS-180-1.<br>
<br>
Copyright (C) 2000, 2001, 2003 Scott G. Miller<br>
<br>
Credits:<br>
Robert Klep <<a href="mailto:robert@ilse.nl" target="_blank">robert@ilse.nl</a>> -- Expansion function fix<br>
NOTE: The canonical source of this file is maintained in GNU coreutils.<br>
*/<br>
<br>
The last line is the key. This apparently came from GNU coreutils.<br>
<br>
>From the SCM logs, sha.c was introduced in approx 2003-07-01 from what it looks<br>
like. So it's a pretty old version. You will need to do some detective work,<br>
and find older versions of coreutils until you find the one that corresponds to<br>
the code that was checked in. Start back in 2003 and work backwards as<br>
necessary. (The version that matches to the original 2003-07-01 should be the<br>
reasonable license to use.)<br></blockquote><div><br></div><div>Ok I found it ! <a href="https://github.com/coreutils/coreutils/blob/v4.5.8/lib/sha.c">https://github.com/coreutils/coreutils/blob/v4.5.8/lib/sha.c</a> <br></div><div><br></div><div>from : <a href="https://github.com/coreutils/coreutils/blob/v4.5.8/COPYING">https://github.com/coreutils/coreutils/blob/v4.5.8/COPYING</a> it looks like it's only GPLV2<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> - how to licence m4/libelf.m4 ? I'd prefer you to tell me exactly what to add in<br>
> order to avoid errors<br>
<br>
The original version of the m4/libelf.m4 was introduced 2001-09-27. It appears<br>
to me that it was written as part of the prelinker, so would be under the<br>
overall license of the prelinker.<br>
<br>
Based on this, my assumption is that it is GPL-2.0<br>
<br>
I do not see any 'or-later' clauses anywhere.<br>
<br></blockquote><div>I have just add "dnl SPDX-License-Identifier: GPL-2.0-only" bellow the "Written by" comment, however should it also be in the resulting template? </div><div>I can add it also at first line of the resulting file if necessary ?<br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> - what about *.C files ? They don't have licence header, they look like C file<br>
> to me so I'd probably add :<br>
> // SPDX-License-Identifier: GPL-2.0-or-later<br>
<br>
There are each simply test cases. They would be covered by the overall<br>
'COPYING' for the package. Thus GPL-2.0<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> - what about testsuite/ files ?<br>
<br>
Same, no specifically stated license will be GPL-2.0.<br>
<br></blockquote><div>Done ! <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Shall every thing just be GPL-2.0-or-later?<br>
<br>
Also just to be clear. As I am NOT the original author of this work, I won't<br>
accept a patch to remove any existing license text from the headers in this<br>
software, but I will accept the SPDX-License-Identifier to be added in addition<br>
to the existing license text.<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If an existing file does not have any License text in it, then we will need to<br>
assume that the COPYING file covers all software unless there is some indicator<br>
it comes from another source with a different license. For items w/o existing<br>
licenses, just adding the SPDX-License-Identifier will be acceptable.<br>
<br>
So in a header similar to:<br>
<br>
/* Copyright (C) 2001, 2002, 2003, 2007 Red Hat, Inc.<br>
Written by Jakub Jelinek <<a href="mailto:jakub@redhat.com" target="_blank">jakub@redhat.com</a>>, 2001.<br>
<br>
This program is free software; you can redistribute it and/or modify<br>
it under the terms of the GNU General Public License as published by<br>
the Free Software Foundation; either version 2, or (at your option)<br>
any later version.<br>
<br>
This program is distributed in the hope that it will be useful,<br>
but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>
GNU General Public License for more details.<br>
<br>
You should have received a copy of the GNU General Public License<br>
along with this program; if not, write to the Free Software Foundation,<br>
Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */<br>
<br>
please add the header between the 'Written by' and the existing license text,<br>
such as:<br>
<br>
/* Copyright (C) 2001, 2002, 2003, 2007 Red Hat, Inc.<br>
Written by Jakub Jelinek <<a href="mailto:jakub@redhat.com" target="_blank">jakub@redhat.com</a>>, 2001.<br>
<br>
SPDX-License-Identifier: GPL-2.0-or-later<br>
<br>
This program is free software; you can redistribute it and/or modify<br>
it under the terms of the GNU General Public License as published by<br>
<br></blockquote><div><br></div><div>Here's the first attempt of the patch, feel free to give me any advice on how to improve it!</div><div><br></div><div>Regards,<br></div></div><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr">
<div style="display:block"><div>
<font face="Raleway, regular">
<table style="padding:20px" border="0">
<tbody>
<tr>
<td style="font-size:13px;color:rgb(255,128,84);text-align:center;padding-right:30px">
<a href="http://www.smile.eu/" target="_blank">
<img style="max-width: 100%; height: auto;" src="http://ftp.smile.fr/client/Communication/signature/img/Logo-new.png" alt="SMILE">
</a><br><br>
<p>20 rue des Jardins<br>
92600 Asnières-sur-Seine</p>
</td>
<td style="border-left:1px solid rgb(59,127,254);padding-left:20px;font-size:13px;color:rgb(255,128,84)">
<div style="color:rgb(255,128,84);font-size:14px">
<b>Yann CARDAILLAC</b>
</div>
<div style="color:rgb(59,127,254);font-size:13px">
Ingénieur Systèmes Embarqués<br>
</div><br>
<div style="color:rgb(59,127,254);font-size:13px">
<span style="white-space:nowrap"><img style="margin-right: 5px;" src="http://ftp.smile.fr/client/Communication/signature/img/mail.png" alt="email" width="12" height="10">
<a href="mailto:yann.cardaillac@smile.fr" style="color:rgb(59,127,254);font-size:13px;text-decoration:none" target="_blank">yann.cardaillac@smile.fr</a>
</span>
<br>
<span style="white-space:nowrap"><img style="margin-right: 5px;" src="http://ftp.smile.fr/client/Communication/signature/img/web.png" alt="url" width="12" height="12">
<a href="http://www.smile.eu" style="color:rgb(59,127,254);font-size:13px;text-decoration:none" target="_blank">http://www.smile.eu</a>
</span>
</div>
<br>
<div>
<span><a style="margin-right:5px" href="https://twitter.com/GroupeSmile" target="_blank"><img src="http://ftp.smile.fr/client/Communication/signature/img/rs-twitter.png" alt="Twitter" style="max-width: 100%; height: auto;"></a></span>
<span><a style="margin-right:5px" href="https://www.facebook.com/smileopensource" target="_blank"><img src="http://ftp.smile.fr/client/Communication/signature/img/rs-facebook.png" alt="Facebook" style="max-width: 100%; height: auto;"></a></span>
<span><a style="margin-right:5px" href="https://www.linkedin.com/company/smile" target="_blank"><img src="http://ftp.smile.fr/client/Communication/signature/img/rs-linkedin.png" alt="LinkedIn" style="max-width: 100%; height: auto;"></a></span>
<span><a style="margin-right:5px" href="https://github.com/Smile-SA" target="_blank"><img src="http://ftp.smile.fr/client/Communication/signature/img/rs-github.png" alt="Github" style="max-width: 100%; height: auto;"></a></span>
</div>
</td>
</tr>
</tbody>
</table>
<br>
<br>
<div style="color:rgb(163,172,181);font-size:10px">
<img src="http://ftp.smile.fr/client/Communication/signature/img/eco.png" alt="eco" width="13" height="11">
Pour la planète, n'imprimez ce mail que si c'est nécessaire
</div>
</font>
</div></div></div></div></div></div></div>