<div dir="ltr"><div>I would rather keep the option to disable openssl, but simply switch it on by default.</div><div><br></div><div>Alex<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 7 Nov 2019 at 13:11, André Draszik <<a href="mailto:git@andred.net">git@andred.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The original commit describes the reason for disabling openssl<br>
so as to get 'more deterministic build[s]' and size-reduction:<br>
commit 6c36fde6ce2e ("libevent: disable openssl by default"),<br>
commit ad130b97a51a in poky.<br>
<br>
Since the introduction of per-recipe sysroots, we always have<br>
deterministic builds.<br>
<br>
Size reduction can be achieved by splitting the package into<br>
multiple sub-packages, which each only provide one of the<br>
shared libraries.<br>
<br>
Hence there appears no reason anymore to disable OpenSSL<br>
support.<br>
<br>
Because this recipe only provides shared libraries which are<br>
handled automatically by bitbake, there is no need to add<br>
the subpackages to the RDEPENDS of PN for backwards<br>
compatibility. The packageing process of dependees will<br>
simply pull in the sub-packages as runtime dependency as<br>
needed.<br>
<br>
This also how Debian splits this up.<br>
<br>
While updating the packaging, we can also drop event_rpcgen.py<br>
which appears to be a tool for generating rpc bindings, i.e.<br>
something that should normally be in -dev. Given Debian<br>
doesn't package this at all, and given it actually requires<br>
python to run but no runtime dependency is stated at the<br>
moment, it would appear that no users of this exist.<br>
<br>
These changes also allow us to build all of nghttp2<br>
out-of-the-box, without affecting existing users.<br>
<br>
Signed-off-by: André Draszik <<a href="mailto:git@andred.net" target="_blank">git@andred.net</a>><br>
---<br>
meta/recipes-support/libevent/<a href="http://libevent_2.1.11.bb" rel="noreferrer" target="_blank">libevent_2.1.11.bb</a> | 13 +++++++++----<br>
1 file changed, 9 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/meta/recipes-support/libevent/<a href="http://libevent_2.1.11.bb" rel="noreferrer" target="_blank">libevent_2.1.11.bb</a> b/meta/recipes-support/libevent/<a href="http://libevent_2.1.11.bb" rel="noreferrer" target="_blank">libevent_2.1.11.bb</a><br>
index f005ab8bda..c746f22118 100644<br>
--- a/meta/recipes-support/libevent/<a href="http://libevent_2.1.11.bb" rel="noreferrer" target="_blank">libevent_2.1.11.bb</a><br>
+++ b/meta/recipes-support/libevent/<a href="http://libevent_2.1.11.bb" rel="noreferrer" target="_blank">libevent_2.1.11.bb</a><br>
@@ -19,9 +19,6 @@ UPSTREAM_CHECK_URI = "<a href="http://libevent.org/" rel="noreferrer" target="_blank">http://libevent.org/</a>"<br>
<br>
S = "${WORKDIR}/${BPN}-${PV}-stable"<br>
<br>
-PACKAGECONFIG ??= ""<br>
-PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"<br>
-<br>
inherit autotools<br>
<br>
# Needed for Debian packaging<br>
@@ -29,11 +26,19 @@ LEAD_SONAME = "<a href="http://libevent-2.1.so" rel="noreferrer" target="_blank">libevent-2.1.so</a>"<br>
<br>
inherit ptest multilib_header<br>
<br>
-DEPENDS = "zlib"<br>
+DEPENDS = "openssl zlib"<br>
+<br>
+PACKAGES =+ "${PN}-core ${PN}-extra ${PN}-openssl ${PN}-pthreads"<br>
+FILES_${PN}-core = "${libdir}/libevent_core*${SOLIBS}"<br>
+FILES_${PN}-extra = "${libdir}/libevent_extra*${SOLIBS}"<br>
+FILES_${PN}-openssl = "${libdir}/libevent_openssl*${SOLIBS}"<br>
+FILES_${PN}-pthreads = "${libdir}/libevent_pthreads-*${SOLIBS}"<br>
<br>
BBCLASSEXTEND = "native nativesdk"<br>
<br>
do_install_append() {<br>
+ rm ${D}${bindir}/event_rpcgen.py<br>
+ rmdir ${D}${bindir}<br>
oe_multilib_header event2/event-config.h<br>
}<br>
<br>
-- <br>
2.23.0.rc1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>