<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 11, 2019 at 8:36 AM Adrian Bunk <<a href="mailto:bunk@stusta.de">bunk@stusta.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Nov 11, 2019 at 07:59:43AM -0800, Khem Raj wrote:<br>
> On Mon, 2019-11-11 at 05:04 -0800, Andre McCurdy wrote:<br>
> > <br>
> > With this merged, we can also drop the hack to force the sqlite<br>
> > static<br>
> > lib to be PIC:<br>
> > <br>
> > <br>
> > <a href="https://git.openembedded.org/openembedded-core/commit/?id=6a58e12d19c539deac9e90679a68438497a42fa4" rel="noreferrer" target="_blank">https://git.openembedded.org/openembedded-core/commit/?id=6a58e12d19c539deac9e90679a68438497a42fa4</a><br>
> <br>
> That would be good but a caution is that if pseudo is just one usecase<br>
> here which brought this issue forward, since we use PIE by default this<br>
> would come up elsewhere too<br>
<br>
The only usecase for building a static library as PIC I am aware of is <br>
when you want to link the static library into a shared library.<br>
<br>
Usually linking a static library into a shared library is a bug and<br>
the link error is preferable since you actually intended to link<br>
with the shared library (the linker automatically uses a static<br>
library when it can't find a shared library).<br>
<br>
There are rare exceptions when this is done intentionally.<br>
Linking a static libsqlite3.a into libpseudo.so was such an exception.<br>
<br>
Whether the non-PIC code is PIE or not does not make a difference.</blockquote><div dir="auto"><br></div><div dir="auto">It’s not directly related to that more to the fact that we disable static libs by default and since this was available some other package might have depended on it inadvertently </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
cu<br>
Adrian<br>
<br>
-- <br>
<br>
"Is there not promise of rain?" Ling Tan asked suddenly out<br>
of the darkness. There had been need of rain for many days.<br>
"Only a promise," Lao Er said.<br>
Pearl S. Buck - Dragon Seed<br>
<br>
</blockquote></div></div>