<div dir="ltr">Thanks, but it still starts and terminates PRServer immediately, right?<div><br></div><div>With your fix, all my builds now start with:</div><div><br></div><div>NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 34335, PID: 9429<br>NOTE: Terminating PRServer...<br>NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 45753, PID: 9433<br></div><div><br></div><div>before this I was using:</div><div><a href="https://github.com/shr-distribution/bitbake/commit/728d9ec3b3448bba91a3cc0d505b804e702aec4b">https://github.com/shr-distribution/bitbake/commit/728d9ec3b3448bba91a3cc0d505b804e702aec4b</a><br></div><div>which doesn't start it just to terminate it, but RP said that my fix doesn't look correct, so I haven't sent it to ML. BTW: bitbake patches should go to bitbake-devel ML not oe-core ML.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 11, 2019 at 11:15 PM <<a href="mailto:gavinli@thegavinli.com">gavinli@thegavinli.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Gavin Li <<a href="mailto:gavin@matician.com" target="_blank">gavin@matician.com</a>><br>
<br>
With PRSERV_HOST = "localhost:0", this message would occasionally pop up<br>
during the initial cache read:<br>
<br>
WARNING: /home/matic/ambayocto/poky/bitbake/lib/bb/cache.py:446: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 45655)><br>
value = pickled.load()<br>
<br>
The file location stated is irrelevant; it just happens to be wherever<br>
CPython decides to run the garbage collector. The issue is that after we<br>
fork off a PRServer, self.socket is also duplicated. The parent side of<br>
it also needs to be closed.<br>
<br>
Signed-off-by: Gavin Li <<a href="mailto:gavin@matician.com" target="_blank">gavin@matician.com</a>><br>
---<br>
bitbake/lib/prserv/serv.py | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py<br>
index be3acec36a..1d9148b817 100644<br>
--- a/bitbake/lib/prserv/serv.py<br>
+++ b/bitbake/lib/prserv/serv.py<br>
@@ -243,6 +243,7 @@ class PRServer(SimpleXMLRPCServer):<br>
try:<br>
pid = os.fork()<br>
if pid > 0:<br>
+ self.socket.close() # avoid ResourceWarning in parent<br>
return pid<br>
except OSError as e:<br>
raise Exception("%s [%d]" % (e.strerror, e.errno))<br>
-- <br>
2.23.0<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>