<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 13, 2019, 7:22 PM Adrian Bunk <<a href="mailto:bunk@stusta.de" rel="noreferrer noreferrer" target="_blank">bunk@stusta.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Dec 13, 2019 at 06:47:33PM -0600, Joshua Watt wrote:<br>
> On Fri, Dec 13, 2019 at 5:10 PM Adrian Bunk <<a href="mailto:bunk@stusta.de" rel="noreferrer noreferrer noreferrer" target="_blank">bunk@stusta.de</a>> wrote:<br>
> ><br>
> > On Fri, Dec 13, 2019 at 04:03:09PM -0600, Joshua Watt wrote:<br>
> > > Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip<br>
> > > RK3399<br>
> > >...<br>
> > > +TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"<br>
> > >...<br>
> ><br>
> > Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled,<br>
> > so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.<br>
> <br>
> I think that's armv8.1-a, the cortex A72 is only armv8-a (at least<br>
> AFAICT), so I think crc would still be an optional feature.<br>
>...<br>
<br>
It is optional for armv8-a, but not for Cortex A53 or A72.<br>
<br>
What matters in practice is that gcc automatically enables it for <br>
cortex-a72.cortex-a53, so the resulting code might not run on<br>
armv8-a hardware without support for crc - things will break<br>
if the tune features are not 100% aligned with whatever gcc<br>
is doing.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I agree, but I can't find anywhere that says crc is enabled by default when the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?</div><div dir="auto"><br></div><div dir="auto">Thanks</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
cu<br>
Adrian<br>
</blockquote></div></div></div>