<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#943634;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="SV" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US">It is not possible to whitelist packages, WHITELIST_<license> only takes recipe names. This seems like a shortcoming, and doesn’t match INCOMPATIBLE_LICENSE, which works
with packages… I am not sure how to address that shortcoming though, as it wouldn’t be right to allow mixing of recipes and packages in WHITELIST_<license>, which means a new variable would need to be introduced for whitelisting individual packages, and I
do not know if it is worth the trouble.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US">Setting INCOMPATIBLE_LICENSE per image is only available with master, so that is not yet an option (we’re currently at Warrior and won’t reach Dunfell till sometime this
fall).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US">That said, I do not have any strong feelings about this patch. The issue was raised by some of our developers, and we have a corresponding patch locally, so I thought I’d
just pass it along. If there is no interest in in, then just drop it.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US">//Peter<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#943634;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Alexander Kanavin <alex.kanavin@gmail.com>
<br>
<b>Sent:</b> den 22 december 2019 14:21<br>
<b>To:</b> Peter Kjellerstedt <peter.kjellerstedt@axis.com><br>
<b>Cc:</b> openembedded-core@lists.openembedded.org<br>
<b>Subject:</b> Re: [OE-core] [master][zeus][PATCH] cairo: Adapt license for cairo-dbg and cairo-src based on contents<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">-dbg and -src packages are unlikely to be shipped to customers. How about either whitelisting them globally, or setting INCOMPABIBLE_LICENSE per image?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">What the patch does with LICENSE-dbg/src feels hack-ish to be honest; also there are other recipes with a similar layout which would also need similar fixups.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Alex<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Sun, 22 Dec 2019 at 14:01, Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com">peter.kjellerstedt@axis.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">*ping*<br>
<br>
//Peter<br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">
openembedded-core-bounces@lists.openembedded.org</a> <openembedded-core-<br>
> <a href="mailto:bounces@lists.openembedded.org" target="_blank">bounces@lists.openembedded.org</a>> On Behalf Of Peter Kjellerstedt<br>
> Sent: den 5 december 2019 23:26<br>
> To: <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.openembedded.org</a><br>
> Subject: [OE-core] [master][zeus][PATCH] cairo: Adapt license for cairo-<br>
> dbg and cairo-src based on contents<br>
> <br>
> Introduce a PACKAGECONFIG "trace" to disable cairo-trace (the only<br>
> part of the code licensed as GPL-3.0, and which is normally packaged<br>
> separately in cairo-perf-utils). By disabling this, we can adapt the<br>
> licenses for cairo-dbg and cairo-src so that they do not include<br>
> "GPLv3+" when trace is disabled and thus they can be used also when,<br>
> e.g., GPL-3.0 is blacklisted in INCOMPATIBLE_LICENSE.<br>
> <br>
> The "trace" PACKAGECONFIG is enabled by default for backwards<br>
> compatibility.<br>
> <br>
> Signed-off-by: Peter Kjellerstedt <<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>><br>
> ---<br>
> meta/recipes-graphics/cairo/<a href="http://cairo_1.16.0.bb" target="_blank">cairo_1.16.0.bb</a> | 8 +++++++-<br>
> 1 file changed, 7 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/meta/recipes-graphics/cairo/<a href="http://cairo_1.16.0.bb" target="_blank">cairo_1.16.0.bb</a> b/meta/recipes-<br>
> graphics/cairo/<a href="http://cairo_1.16.0.bb" target="_blank">cairo_1.16.0.bb</a><br>
> index e3de3f6164..36a7b3c180 100644<br>
> --- a/meta/recipes-graphics/cairo/<a href="http://cairo_1.16.0.bb" target="_blank">cairo_1.16.0.bb</a><br>
> +++ b/meta/recipes-graphics/cairo/<a href="http://cairo_1.16.0.bb" target="_blank">cairo_1.16.0.bb</a><br>
> @@ -17,6 +17,10 @@ LICENSE_${PN}-doc = "MPL-1.1 | LGPLv2.1"<br>
> LICENSE_${PN}-gobject = "MPL-1.1 | LGPLv2.1"<br>
> LICENSE_${PN}-script-interpreter = "MPL-1.1 | LGPLv2.1"<br>
> LICENSE_${PN}-perf-utils = "GPLv3+"<br>
> +# Adapt the licenses for cairo-dbg and cairo-src depending on whether<br>
> +# cairo-trace is being built.<br>
> +LICENSE_${PN}-dbg = "(MPL-1.1 |<br>
> LGPLv2.1)<a href="mailto:$%7b@bb.utils.contains('PACKAGECONFIG">${@bb.utils.contains('PACKAGECONFIG</a>', 'trace', ' & GPLv3+', '',<br>
> d)}"<br>
> +LICENSE_${PN}-src = "(MPL-1.1 |<br>
> LGPLv2.1)<a href="mailto:$%7b@bb.utils.contains('PACKAGECONFIG">${@bb.utils.contains('PACKAGECONFIG</a>', 'trace', ' & GPLv3+', '',<br>
> d)}"<br>
> <br>
> LIC_FILES_CHKSUM = "<a href="file://COPYING;md5=e73e999e0c72b5ac9012424fa157ad77">file://COPYING;md5=e73e999e0c72b5ac9012424fa157ad77</a>"<br>
> <br>
> @@ -40,7 +44,8 @@ X11DEPENDS = "virtual/libx11 libsm libxrender libxext"<br>
> <br>
> PACKAGECONFIG ??= "<a href="mailto:$%7b@bb.utils.filter('DISTRO_FEATURES',%20'directfb',%20d)%7d%0b%3e%20\%0b%3e %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 $%7b@bb.utils.contains('DISTRO_FEATURES',%20'x11',%20'x11%0b%3e%20xcb',%20'',%20d)%7d%20\%0b%3e%20- %20 %20 %20 %20 %20 %20 %20 %20 %20 $%7b@bb.utils.contains('DISTRO_FEATURES',%20'x11%20opengl',%0b%3e%20'opengl',%20'',%20d)%7d">${@bb.utils.filter('DISTRO_FEATURES',
'directfb', d)}<br>
> \<br>
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11<br>
> xcb', '', d)} \<br>
> - ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl',<br>
> 'opengl', '', d)}</a>"<br>
> + <a href="mailto:$%7b@bb.utils.contains('DISTRO_FEATURES">${@bb.utils.contains('DISTRO_FEATURES</a>', 'x11 opengl',<br>
> 'opengl', '', d)} \<br>
> + trace"<br>
> <br>
> PACKAGECONFIG[x11] = "--with-x=yes -enable-xlib,--with-x=no --disable-<br>
> xlib,${X11DEPENDS}"<br>
> PACKAGECONFIG[xcb] = "--enable-xcb,--disable-xcb,libxcb"<br>
> @@ -49,6 +54,7 @@ PACKAGECONFIG[valgrind] = "--enable-valgrind=yes,--<br>
> disable-valgrind,valgrind"<br>
> PACKAGECONFIG[egl] = "--enable-egl=yes,--disable-egl,virtual/egl"<br>
> PACKAGECONFIG[glesv2] = "--enable-glesv2,--disable-<br>
> glesv2,virtual/libgles2"<br>
> PACKAGECONFIG[opengl] = "--enable-gl,--disable-gl,virtual/libgl"<br>
> +PACKAGECONFIG[trace] = "--enable-trace,--disable-trace"<br>
> <br>
> EXTRA_OECONF += " \<br>
> <a href="mailto:$%7b@bb.utils.contains('TARGET_FPU">${@bb.utils.contains('TARGET_FPU</a>', 'soft', '--disable-some-floating-<br>
> point', '', d)} \<br>
> --<br>
> 2.21.0<br>
> <br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">
http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>