<div dir="ltr"><div>I think I have a better patch for this:</div><div><a href="http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates&id=c2fc852501414b06e6587d97d3bc944a4650906e">http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates&id=c2fc852501414b06e6587d97d3bc944a4650906e</a></div><div><br></div><div>Rather than hardcode upstream-specific targets, my patch uses a variable that upstream uses to skip the tests.</div><div><br></div><div>Alex<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 20 Jan 2020 at 17:08, Mingde (Matthew) Zeng <<a href="mailto:matthew.zeng@windriver.com">matthew.zeng@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
As per do_compile_ptest first appeared in commit 1f7aaf76f4aa7875f05f4b838a5ec4594a4c35dc,<br>
regress/unittests/ binaries are already skipped.<br>
<br>
This will trigger a Makefile error when running ptest:<br>
```sh<br>
/bin/sh: line 4: /usr/lib/openssh/ptest/regress/unittests/sshbuf/test_sshbuf: No such file or directory<br>
make: *** [Makefile:243: unit] Error 127<br>
make: Target 'tests' not remade because of errors.<br>
```<br>
<br>
openssh/regress/Makefile:<br>
```<br>
tests: prep file-tests t-exec unit<br>
```<br>
<br>
Therefore we do not `make tests` as it consists of unit tests, we<br>
`make prep file-tests t-exec` instead.<br>
<br>
Signed-off-by: Matthew Zeng<<a href="mailto:Matthew.Zeng@windriver.com" target="_blank">Matthew.Zeng@windriver.com</a>><br>
<br>
---<br>
meta/recipes-connectivity/openssh/openssh/run-ptest | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-connectivity/openssh/openssh/run-ptest b/meta/recipes-connectivity/openssh/openssh/run-ptest<br>
index daf62cca5b..e5270ceade 100755<br>
--- a/meta/recipes-connectivity/openssh/openssh/run-ptest<br>
+++ b/meta/recipes-connectivity/openssh/openssh/run-ptest<br>
@@ -4,7 +4,8 @@ export TEST_SHELL=sh<br>
<br>
cd regress<br>
sed -i "/\t\tagent-ptrace /d" Makefile<br>
-make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" tests \<br>
+<br>
+make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" prep file-tests t-exec \<br>
| sed -u -e 's/^skipped/SKIP: /g' -e 's/^ok /PASS: /g' -e 's/^failed/FAIL: /g'<br>
<br>
SSHAGENT=`which ssh-agent`<br>
@@ -41,4 +42,3 @@ EOF<br>
${SSHAGENT} -k > /dev/null<br>
fi<br>
userdel openssh-test<br>
-<br>
--<br>
2.24.0<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>