<div dir="ltr"><div>Now that ptests are actually run on the autobuilder for both x86 and arm64, we can look at whether anything still fails with this patchset. I tested on the x86 with 100% pass, but not on arm.</div><div><br></div><div>My goal is to drop @expectedfail from ptests, because otherwise ptests keep regressing with nobody caring or paying attention. Better to catch and reject regressions when they happen I think.<br></div><div></div><div><br></div><div>Alex<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 27 Jan 2020 at 16:53, akuster808 <<a href="mailto:akuster808@gmail.com">akuster808@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 1/27/20 6:19 AM, Alexander Kanavin wrote:<br>
> Particularly, one test is disabled as it is failing everywhere,<br>
> two patches that actually cause failures are dropped and<br>
> some binaries are prevented from being stripped where that is<br>
> expected.<br>
So this will address either<br>
<a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=13666" rel="noreferrer" target="_blank">https://bugzilla.yoctoproject.org/show_bug.cgi?id=13666</a> and<br>
<a href="https://bugzilla.yoctoproject.org/show_bug.cgi?id=13520" rel="noreferrer" target="_blank">https://bugzilla.yoctoproject.org/show_bug.cgi?id=13520</a> ?<br>
<br>
- armin<br>
><br>
> Signed-off-by: Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>><br>
> ---<br>
> ...eak_cmsg.stderr.exp-adjust-tmp-paths.patch | 34 +++++++++++++++++++<br>
> ...rind-adjust-std_list-expected-output.patch | 32 -----------------<br>
> ...Dereference-pthread_t-before-adding-.patch | 32 -----------------<br>
> .../valgrind/<a href="http://valgrind_3.15.0.bb" rel="noreferrer" target="_blank">valgrind_3.15.0.bb</a> | 23 +++++++++++--<br>
> 4 files changed, 55 insertions(+), 66 deletions(-)<br>
> create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch<br>
> delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0002-valgrind-adjust-std_list-expected-output.patch<br>
> delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0006-pth_detached3.c-Dereference-pthread_t-before-adding-.patch<br>
><br>
> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch<br>
> new file mode 100644<br>
> index 00000000000..d641998d721<br>
> --- /dev/null<br>
> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch<br>
> @@ -0,0 +1,34 @@<br>
> +From f405297d3382cd98391d02f397e2387da1f42879 Mon Sep 17 00:00:00 2001<br>
> +From: Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>><br>
> +Date: Fri, 24 Jan 2020 17:55:39 +0100<br>
> +Subject: [PATCH] none/tests/fdleak_cmsg.stderr.exp: adjust /tmp paths<br>
> +<br>
> +In oe-core, /tmp is linked to /var/volatile/tmp and<br>
> +valgrind output changes accordingly<br>
> +<br>
> +Upstream-Status: Inappropriate [oe-core specific]<br>
> +Signed-off-by: Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>><br>
> +---<br>
> + none/tests/fdleak_cmsg.stderr.exp | 4 ++--<br>
> + 1 file changed, 2 insertions(+), 2 deletions(-)<br>
> +<br>
> +diff --git a/none/tests/fdleak_cmsg.stderr.exp b/none/tests/fdleak_cmsg.stderr.exp<br>
> +index 6e5a797b9..0ede1ab18 100644<br>
> +--- a/none/tests/fdleak_cmsg.stderr.exp<br>
> ++++ b/none/tests/fdleak_cmsg.stderr.exp<br>
> +@@ -25,10 +25,10 @@ Open file descriptor ...: /dev/null<br>
> + <br>
> + <br>
> + FILE DESCRIPTORS: 6 open at exit.<br>
> +-Open file descriptor ...: /tmp/data2<br>
> ++Open file descriptor ...: ...<br>
> + ...<br>
> + <br>
> +-Open file descriptor ...: /tmp/data1<br>
> ++Open file descriptor ...: ...<br>
> + ...<br>
> + <br>
> + Open AF_UNIX socket ...: <unknown><br>
> +-- <br>
> +2.17.1<br>
> +<br>
> diff --git a/meta/recipes-devtools/valgrind/valgrind/0002-valgrind-adjust-std_list-expected-output.patch b/meta/recipes-devtools/valgrind/valgrind/0002-valgrind-adjust-std_list-expected-output.patch<br>
> deleted file mode 100644<br>
> index a82972ec1b6..00000000000<br>
> --- a/meta/recipes-devtools/valgrind/valgrind/0002-valgrind-adjust-std_list-expected-output.patch<br>
> +++ /dev/null<br>
> @@ -1,32 +0,0 @@<br>
> -From 6e1e9265b03cf51d09c028d657fe826d7156a783 Mon Sep 17 00:00:00 2001<br>
> -From: Randy MacLeod <<a href="mailto:Randy.MacLeod@windriver.com" target="_blank">Randy.MacLeod@windriver.com</a>><br>
> -Date: Mon, 13 May 2019 17:26:26 -0400<br>
> -Subject: [PATCH 2/2] valgrind: adjust std_list expected output<br>
> -<br>
> -The run-ptest script uses a custom --yocto-ptest option<br>
> -to change the summary statistics that valgrind issues<br>
> -to a format that matches what ptest-runner expects.<br>
> -<br>
> -Only this std_list test which checks that strcpy() works<br>
> -properly on Ubuntu-12.04 and later is affected by this change.<br>
> -It's normal output when called with --yocto-ptest is a blank<br>
> -line so adjust the expected output.<br>
> -<br>
> -Upstream-Status: Inappropriate [Yocto specific]<br>
> -<br>
> -Signed-off-by: Randy MacLeod <<a href="mailto:Randy.MacLeod@windriver.com" target="_blank">Randy.MacLeod@windriver.com</a>><br>
> ----<br>
> - drd/tests/std_list.stderr.exp | 2 --<br>
> - 1 file changed, 2 deletions(-)<br>
> -<br>
> -diff --git a/drd/tests/std_list.stderr.exp b/drd/tests/std_list.stderr.exp<br>
> -index d18786f80..8b1378917 100644<br>
> ---- a/drd/tests/std_list.stderr.exp<br>
> -+++ b/drd/tests/std_list.stderr.exp<br>
> -@@ -1,3 +1 @@<br>
> - <br>
> --<br>
> --ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)<br>
> --- <br>
> -2.17.0<br>
> -<br>
> diff --git a/meta/recipes-devtools/valgrind/valgrind/0006-pth_detached3.c-Dereference-pthread_t-before-adding-.patch b/meta/recipes-devtools/valgrind/valgrind/0006-pth_detached3.c-Dereference-pthread_t-before-adding-.patch<br>
> deleted file mode 100644<br>
> index 05886c743dc..00000000000<br>
> --- a/meta/recipes-devtools/valgrind/valgrind/0006-pth_detached3.c-Dereference-pthread_t-before-adding-.patch<br>
> +++ /dev/null<br>
> @@ -1,32 +0,0 @@<br>
> -From a6547fc17c120dbd95b852f50b0c4bdee4fedb9a Mon Sep 17 00:00:00 2001<br>
> -From: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> -Date: Sat, 10 Jun 2017 01:20:32 -0700<br>
> -Subject: [PATCH 6/6] pth_detached3.c: Dereference pthread_t before adding<br>
> - offset to it<br>
> -<br>
> -Fixes<br>
> -error: invalid use of undefined type 'struct __pthread'<br>
> -<br>
> -Upstream-Status: Pending<br>
> -<br>
> -Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> ----<br>
> - drd/tests/pth_detached3.c | 2 +-<br>
> - 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> -<br>
> -diff --git a/drd/tests/pth_detached3.c b/drd/tests/pth_detached3.c<br>
> -index c02eef1..35d43a6 100644<br>
> ---- a/drd/tests/pth_detached3.c<br>
> -+++ b/drd/tests/pth_detached3.c<br>
> -@@ -21,7 +21,7 @@ int main(int argc, char** argv)<br>
> - pthread_detach(thread);<br>
> - <br>
> - /* Invoke pthread_detach() with an invalid thread ID. */<br>
> -- pthread_detach(thread + 8);<br>
> -+ pthread_detach((pthread_t*)(&thread + 8));<br>
> - <br>
> - fprintf(stderr, "Finished.\n");<br>
> - <br>
> --- <br>
> -2.13.1<br>
> -<br>
> diff --git a/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.15.0.bb" rel="noreferrer" target="_blank">valgrind_3.15.0.bb</a> b/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.15.0.bb" rel="noreferrer" target="_blank">valgrind_3.15.0.bb</a><br>
> index 6a3834cfdc6..0f86aa44ca6 100644<br>
> --- a/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.15.0.bb" rel="noreferrer" target="_blank">valgrind_3.15.0.bb</a><br>
> +++ b/meta/recipes-devtools/valgrind/<a href="http://valgrind_3.15.0.bb" rel="noreferrer" target="_blank">valgrind_3.15.0.bb</a><br>
> @@ -29,7 +29,6 @@ SRC_URI = "<a href="https://sourceware.org/pub/valgrind/valgrind-$%7BPV%7D.tar.bz2" rel="noreferrer" target="_blank">https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2</a> \<br>
> file://0003-correct-include-directive-path-for-config.h.patch \<br>
> file://0004-pth_atfork1.c-Define-error-API-for-musl.patch \<br>
> file://0005-tc20_verifywrap.c-Fake-__GLIBC_PREREQ-with-musl.patch \<br>
> - file://0006-pth_detached3.c-Dereference-pthread_t-before-adding-.patch \<br>
> file://0001-memcheck-arm64-Define-__THROW-if-not-already-defined.patch \<br>
> file://0002-memcheck-x86-Define-__THROW-if-not-defined.patch \<br>
> file://0003-tests-seg_override-Replace-__modify_ldt-with-syscall.patch \<br>
> @@ -38,9 +37,9 @@ SRC_URI = "<a href="https://sourceware.org/pub/valgrind/valgrind-$%7BPV%7D.tar.bz2" rel="noreferrer" target="_blank">https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2</a> \<br>
> file://0001-Make-local-functions-static-to-avoid-assembler-error.patch \<br>
> file://0001-Return-a-valid-exit_code-from-vg_regtest.patch \<br>
> file://0001-valgrind-filter_xml_frames-do-not-filter-usr.patch \<br>
> - file://0002-valgrind-adjust-std_list-expected-output.patch \<br>
> file://0001-adjust-path-filter-for-2-memcheck-tests.patch \<br>
> file://s390x_vec_op_t.patch \<br>
> + file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch \<br>
> "<br>
> SRC_URI[md5sum] = "46e5fbdcbc3502a5976a317a0860a975"<br>
> SRC_URI[sha256sum] = "417c7a9da8f60dd05698b3a7bc6002e4ef996f14c13f0ff96679a16873e78ab1"<br>
> @@ -205,4 +204,24 @@ do_install_ptest() {<br>
> # handle multilib<br>
> sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest<br>
> sed -i s:@bindir@:${bindir}:g ${D}${PTEST_PATH}/run-ptest<br>
> +<br>
> + # This test fails on the host as well, using both 3.15 and git master (as of Jan 24 2020)<br>
> + # <a href="https://bugs.kde.org/show_bug.cgi?id=402833" rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.cgi?id=402833</a><br>
> + rm ${D}${PTEST_PATH}/memcheck/tests/overlap.vgtest<br>
> +<br>
> + # As the binary isn't stripped or debug-splitted, the source file isn't fetched<br>
> + # via dwarfsrcfiles either, so it needs to be installed manually.<br>
> + mkdir -p ${D}/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/${BP}/none/tests/<br>
> + install ${S}/none/tests/tls.c ${D}/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/${BP}/none/tests/<br>
> }<br>
> +<br>
> +# avoid stripping some generated binaries otherwise some of the tests will fail<br>
> +# run-strip-reloc.sh, run-strip-strmerge.sh and so on will fail<br>
> +INHIBIT_PACKAGE_STRIP_FILES = "\<br>
> + ${PKGD}${PTEST_PATH}/none/tests/tls \<br>
> + ${PKGD}${PTEST_PATH}/none/tests/tls.so \<br>
> + ${PKGD}${PTEST_PATH}/none/tests/tls2.so \<br>
> + ${PKGD}${PTEST_PATH}/helgrind/tests/tc09_bad_unlock \<br>
> + ${PKGD}${PTEST_PATH}/memcheck/tests/manuel1 \<br>
> + ${PKGD}${PTEST_PATH}/drd/tests/pth_detached3 \<br>
> +"<br>
<br>
</blockquote></div>