<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 5, 2020, 6:12 AM Richard Purdie &lt;<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Adding newline characters between the packages in the failure output<br>
massively improves readability.<br>
<br>
Also ensure to output ipk failures when there are deb failures by<br>
calling self.fail() at the end, else sometimes only partial differences<br>
are returned.<br>
<br>
Signed-off-by: Richard Purdie &lt;<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank" rel="noreferrer">richard.purdie@linuxfoundation.org</a>&gt;<br>
---<br>
 meta/lib/oeqa/selftest/cases/reproducible.py | 9 +++++++--<br>
 1 file changed, 7 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/meta/lib/oeqa/selftest/cases/reproducible.py b/meta/lib/oeqa/selftest/cases/reproducible.py<br>
index 04dc46f38a0..f6433c9a02b 100644<br>
--- a/meta/lib/oeqa/selftest/cases/reproducible.py<br>
+++ b/meta/lib/oeqa/selftest/cases/reproducible.py<br>
@@ -185,6 +185,8 @@ class ReproducibleTests(OESelftestTestCase):<br>
         # NOTE: The temp directories from the reproducible build are purposely<br>
         # kept after the build so it can be diffed for debugging.<br>
<br>
+        fails = []<br>
+<br>
         for c in self.package_classes:<br>
             with self.subTest(package_class=c):<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">It too bad subtests are broken. If we can&#39;t handle failed subtests, we can remove this line that creates the subtest in the first place.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                 package_class = &#39;package_&#39; + c<br>
@@ -208,8 +210,11 @@ class ReproducibleTests(OESelftestTestCase):<br>
                         self.copy_file(d.test, &#39;/&#39;.join([save_dir, d.test]))<br>
<br>
                 if result.missing or result.different:<br>
-                    self.fail(&quot;The following %s packages are missing or different: %s&quot; %<br>
-                            (c, &#39; &#39;.join(r.test for r in (result.missing + result.different))))<br>
+                    fails.append(&quot;The following %s packages are missing or different: %s&quot; %<br>
+                            (c, &#39;\n&#39;.join(r.test for r in (result.missing + result.different))))<br>
+<br>
+        if fails:<br>
+            self.fail(&#39;\n&#39;.join(fails))<br>
<br>
         # Clean up empty directories<br>
         if self.save_results:<br>
-- <br>
2.20.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank" rel="noreferrer">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div></div>