<div dir="ltr">Awesome, thanks! <br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 7, 2020 at 3:45 PM Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com">bruce.ashfield@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Feb 7, 2020 at 9:20 AM Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>> wrote:<br>
><br>
> With the LD="${KERNEL_LD}" removed here, the build with ld-is-gold doesn't work anymore again.<br>
><br>
> Why did you remove it?<br>
<br>
I removed it by mistake, and fixed it .. but apparently sent the wrong<br>
version of the patch.<br>
<br>
I'll send a v2 shortly!<br>
<br>
Bruce<br>
<br>
><br>
> On Thu, Feb 6, 2020 at 6:37 PM <<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>> wrote:<br>
>><br>
>> From: Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>><br>
>><br>
>> To ensure that the kernel linker is used when allno/mod/yes config<br>
>> merge_config steps were executed, the call to make was tweaked to<br>
>> explicitly pass LD.<br>
>><br>
>> But since the variable wasn't quoted, any parameters to LD (like<br>
>> the sysroot) were mistakenly passed to make, and hence could trigger<br>
>> an error on some architectures.<br>
>><br>
>> We also tweak the logging to hightlight errors like this in the<br>
>> future and avoid losing it in the noise of merge configs sometimes<br>
>> overly verbose output.<br>
>><br>
>> Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@gmail.com" target="_blank">bruce.ashfield@gmail.com</a>><br>
>> ---<br>
>> meta/classes/kernel-yocto.bbclass | 10 +++++++---<br>
>> .../recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" rel="noreferrer" target="_blank">kern-tools-native_git.bb</a> | 2 +-<br>
>> 2 files changed, 8 insertions(+), 4 deletions(-)<br>
>><br>
>> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass<br>
>> index 918d101d3d..31ea42580c 100644<br>
>> --- a/meta/classes/kernel-yocto.bbclass<br>
>> +++ b/meta/classes/kernel-yocto.bbclass<br>
>> @@ -352,10 +352,14 @@ do_kernel_configme() {<br>
>> bbfatal_log "Could not find configuration queue (${meta_dir}/config.queue)"<br>
>> fi<br>
>><br>
>> - CFLAGS="${CFLAGS} ${TOOLCHAIN_OPTIONS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" HOSTCPP="${BUILD_CPP}" CC="${KERNEL_CC}" LD="${KERNEL_LD}" ARCH=${ARCH} merge_config.sh -O ${B} ${config_flags} ${configs}<br>
>> -<br>
>> + CFLAGS="${CFLAGS} ${TOOLCHAIN_OPTIONS}" HOSTCC="${BUILD_CC} ${BUILD_CFLAGS} ${BUILD_LDFLAGS}" HOSTCPP="${BUILD_CPP}" CC="${KERNEL_CC}" ARCH=${ARCH} merge_config.sh -O ${B} ${config_flags} ${configs} > ${meta_dir}/cfg/merge_config_build.log 2>&1<br>
>> if [ $? -ne 0 -o ! -f ${B}/.config ]; then<br>
>> - bbfatal_log "Could not configure ${KMACHINE}-${LINUX_KERNEL_TYPE}"<br>
>> + bberror "Could not generate a .config for ${KMACHINE}-${LINUX_KERNEL_TYPE}"<br>
>> + if [ ${KCONF_AUDIT_LEVEL} -gt 1 ]; then<br>
>> + bbfatal_log "`cat ${meta_dir}/cfg/merge_config_build.log`"<br>
>> + else<br>
>> + bbfatal_log "Details can be found at: ${S}/${meta_dir}/cfg/merge_config_build.log"<br>
>> + fi<br>
>> fi<br>
>><br>
>> if [ ! -z "${LINUX_VERSION_EXTENSION}" ]; then<br>
>> diff --git a/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" rel="noreferrer" target="_blank">kern-tools-native_git.bb</a> b/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" rel="noreferrer" target="_blank">kern-tools-native_git.bb</a><br>
>> index f263421234..4f1af731d6 100644<br>
>> --- a/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" rel="noreferrer" target="_blank">kern-tools-native_git.bb</a><br>
>> +++ b/meta/recipes-kernel/kern-tools/<a href="http://kern-tools-native_git.bb" rel="noreferrer" target="_blank">kern-tools-native_git.bb</a><br>
>> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://tools/kgit;beginline=5;endline=9;md5=9c30e971d435e249<br>
>><br>
>> DEPENDS = "git-native"<br>
>><br>
>> -SRCREV = "388b67974deb2176c06994a325676cbf23e5fce8"<br>
>> +SRCREV = "c66833e1caac25279a5052fceb13213f5e4f79f9"<br>
>> PR = "r12"<br>
>> PV = "0.2+git${SRCPV}"<br>
>><br>
>> --<br>
>> 2.19.1<br>
>><br>
>> --<br>
>> _______________________________________________<br>
>> Openembedded-core mailing list<br>
>> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
>> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
<br>
<br>
<br>
-- <br>
- Thou shalt not follow the NULL pointer, for chaos and madness await<br>
thee at its end<br>
- "Use the force Harry" - Gandalf, Star Trek II<br>
</blockquote></div>