<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hi Alex,<br>
<br>
Thanks for the pointers.<br>
<br>
Yes, too bad - the github mirror is out of date, it would be nice to
have commit history.<br>
<br>
I will setup x265_3.2.1.bb recipe use tarballs to fetch.<br>
<br>
<br>
<div class="moz-cite-prefix">On 2020-02-08 6:47 a.m., Alexander
Kanavin wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CANNYZj_WspzruDbxjnz8bNJYQhdQcgz8TocD2vACpFO7s-vfeQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>What I meant is that upstream is actually tagging releases:</div>
<div><a href="https://github.com/videolan/x265/releases"
moz-do-not-send="true">https://github.com/videolan/x265/releases</a></div>
<div>and therefore we should package the latest release, rather
than a random commit. <br>
</div>
<div><br>
</div>
<div>Which means you should name the recipe <a
href="http://x265_3.1.2.bb" moz-do-not-send="true">x265_3.1.2.bb</a>
and set SRCREV to match the 3.1.2 tag. Going forward, the
recipe should be updated the same way: rename file to the new
version, update SRCREV.</div>
<div><br>
</div>
<div>Another problem is that github is not synced properly with
the original x265 repo, and is several months behind. SRC_URI
should probably refer to <a
href="https://bitbucket.org/multicoreware/x265/src/default/"
moz-do-not-send="true">https://bitbucket.org/multicoreware/x265/src/default/</a></div>
<div>Alternatively, don't use git at all and fetch tarballs: <a
href="http://ftp.videolan.org/pub/videolan/x265/"
moz-do-not-send="true">http://ftp.videolan.org/pub/videolan/x265/</a></div>
<div><br>
</div>
<div>Alex<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, 8 Feb 2020 at 00:28,
Scott Branden <<a href="mailto:scott.branden@broadcom.com"
moz-do-not-send="true">scott.branden@broadcom.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div> Hi Alex,<br>
<br>
more comment below about PV.<br>
<br>
<div>On 2020-02-07 2:26 p.m., Scott Branden wrote:<br>
</div>
<blockquote type="cite"> HI Alex,<br>
<br>
<div>On 2020-02-07 2:09 p.m., Alexander Kanavin wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Can you also enable x265 in ffmpeg and gstreamer
plugins recipes, so there would be actual users of
the codec in oe-core?</div>
</div>
</blockquote>
I do have a patch for ffmpeg and have tested that works.
I'll add that to the patch series.<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Also, x265 git repo does have tagged releases,
and so PV/SRCREV in recipe should be set to match a
release tag.<br>
</div>
</div>
</blockquote>
You'll have to help me out a little here on exactly what
you want. <br>
<br>
This is based off the stable tag.<br>
I already specified the SRCREV in the recipe.<br>
<br>
Do you want PV to be:<br>
PV = "stable+git${SRCPV}"<br>
<br>
?<br>
</blockquote>
I was trying to follow the x264 recipe.<br>
<br>
Do you want me do something like name the recipe <a
href="http://x265_stable.bb" target="_blank"
moz-do-not-send="true">x265_stable.bb</a> instead and not
specify PV?<br>
<blockquote type="cite">
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>Alex<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, 7 Feb 2020
at 22:35, Scott Branden via Openembedded-core <<a
href="mailto:openembedded-core@lists.openembedded.org" target="_blank"
moz-do-not-send="true">openembedded-core@lists.openembedded.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Add x265 recipe
from latest revision of stable branch.<br>
<br>
Signed-off-by: Scott Branden <<a
href="mailto:scott.branden@broadcom.com"
target="_blank" moz-do-not-send="true">scott.branden@broadcom.com</a>><br>
---<br>
meta/recipes-multimedia/x265/<a
href="http://x265_git.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">x265_git.bb</a>
| 21 +++++++++++++++++++++<br>
1 file changed, 21 insertions(+)<br>
create mode 100644 meta/recipes-multimedia/x265/<a
href="http://x265_git.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">x265_git.bb</a><br>
<br>
diff --git a/meta/recipes-multimedia/x265/<a
href="http://x265_git.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">x265_git.bb</a>
b/meta/recipes-multimedia/x265/<a
href="http://x265_git.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">x265_git.bb</a><br>
new file mode 100644<br>
index 0000000000..7c230e2b1e<br>
--- /dev/null<br>
+++ b/meta/recipes-multimedia/x265/<a
href="http://x265_git.bb" rel="noreferrer"
target="_blank" moz-do-not-send="true">x265_git.bb</a><br>
@@ -0,0 +1,21 @@<br>
+SUMMARY = "H.265/HEVC video encoder"<br>
+DESCRIPTION = "A free software library and
application for encoding video streams into the
H.265/HEVC format."<br>
+HOMEPAGE = "<a
href="http://www.videolan.org/developers/x265.html"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://www.videolan.org/developers/x265.html</a>"<br>
+<br>
+LICENSE = "GPLv2"<br>
+LICENSE_FLAGS = "commercial"<br>
+LIC_FILES_CHKSUM = <a moz-do-not-send="true">"file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"</a><br>
+<br>
+DEPENDS = "nasm-native"<br>
+DEPENDS = "gnutls zlib libpcre"<br>
+<br>
+SRC_URI = "git://<a
href="http://github.com/videolan/x265;branch=stable"
rel="noreferrer" target="_blank"
moz-do-not-send="true">github.com/videolan/x265;branch=stable</a>
\<br>
+ "<br>
+<br>
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"<br>
+<br>
+S = "${WORKDIR}/git/source"<br>
+<br>
+inherit lib_package pkgconfig cmake<br>
+<br>
+AS[unexport] = "1"<br>
-- <br>
2.17.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a
href="mailto:Openembedded-core@lists.openembedded.org"
target="_blank" moz-do-not-send="true">Openembedded-core@lists.openembedded.org</a><br>
<a
href="http://lists.openembedded.org/mailman/listinfo/openembedded-core"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>
</div>
</blockquote>
<br>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>