<div><div dir="auto">Upstream status should be in the patch file that you added to the recipe (just above the signed off), not in the commit message.</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue 11. Feb 2020 at 17.37, Oleksandr Popovych via Openembedded-core <<a href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.openembedded.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For ptest support for this package several additional patches and<br>
run-ptest script were added and recipe was changed.<br>
<br>
Upstream-Status: Submitted [<a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.openembedded.org</a>]<br>
<br>
Signed-off-by: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
---<br>
...d-Makefile-targets-for-ptest-support.patch | 38 ++++++++++++++<br>
...ort-for-ptests-in-form-of-new-target.patch | 31 ++++++++++++<br>
...ed-suitable-format-of-tests-in-ptest.patch | 50 +++++++++++++++++++<br>
meta/recipes-core/expat/expat/run-ptest | 3 ++<br>
meta/recipes-core/expat/<a href="http://expat_2.2.9.bb" rel="noreferrer" target="_blank">expat_2.2.9.bb</a> | 12 ++++-<br>
5 files changed, 133 insertions(+), 1 deletion(-)<br>
create mode 100644 meta/recipes-core/expat/expat/0001-expat-Added-Makefile-targets-for-ptest-support.patch<br>
create mode 100644 meta/recipes-core/expat/expat/0002-expat-Added-support-for-ptests-in-form-of-new-target.patch<br>
create mode 100644 meta/recipes-core/expat/expat/0003-expat-Added-suitable-format-of-tests-in-ptest.patch<br>
create mode 100644 meta/recipes-core/expat/expat/run-ptest<br>
<br>
diff --git a/meta/recipes-core/expat/expat/0001-expat-Added-Makefile-targets-for-ptest-support.patch b/meta/recipes-core/expat/expat/0001-expat-Added-Makefile-targets-for-ptest-support.patch<br>
new file mode 100644<br>
index 0000000000..32488060ee<br>
--- /dev/null<br>
+++ b/meta/recipes-core/expat/expat/0001-expat-Added-Makefile-targets-for-ptest-support.patch<br>
@@ -0,0 +1,38 @@<br>
+From ce803ec3d7b095cb55686f9cd5d3f01d34a31a5e Mon Sep 17 00:00:00 2001<br>
+From: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+Date: Thu, 6 Feb 2020 13:41:45 +0200<br>
+Subject: [PATCH 1/3] expat: Added Makefile targets for ptest support<br>
+<br>
+install-ptest, runtests and check tagrets are added.<br>
+<br>
+Signed-off-by: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+---<br>
+ Makefile.am | 15 +++++++++++++++<br>
+ 1 file changed, 15 insertions(+)<br>
+<br>
+diff --git a/Makefile.am b/Makefile.am<br>
+index 5e1d37d..c63b44a 100644<br>
+--- a/Makefile.am<br>
++++ b/Makefile.am<br>
+@@ -152,3 +152,18 @@ qa:<br>
+ QA_COMPILER=clang QA_SANITIZER=memory ./qa.sh<br>
+ QA_COMPILER=clang QA_SANITIZER=undefined ./qa.sh<br>
+ QA_COMPILER=gcc QA_PROCESSOR=gcov ./qa.sh<br>
++<br>
++.PHONY: install-ptest<br>
++install-ptest:<br>
++ echo $(S)<br>
++ (if [ -d tests/.libs ] ; then cd tests/.libs; fi; \<br>
++ install runtests runtestspp $(DESTDIR))<br>
++ cp Makefile $(DESTDIR)<br>
++ sed -i -e 's|^Makefile:|_Makefile:|' $(DESTDIR)/Makefile<br>
++<br>
++.PHONY: runtests<br>
++runtests:<br>
++ @echo "C variant of tests:"<br>
++ @$(CHECKER) ./runtests$(EXEEXT) -q <br>
++ @echo "C++ variant of tests:"<br>
++ @$(CHECKER) ./runtestspp$(EXEEXT) -q<br>
+-- <br>
+2.17.1<br>
+<br>
diff --git a/meta/recipes-core/expat/expat/0002-expat-Added-support-for-ptests-in-form-of-new-target.patch b/meta/recipes-core/expat/expat/0002-expat-Added-support-for-ptests-in-form-of-new-target.patch<br>
new file mode 100644<br>
index 0000000000..cf8a2495e9<br>
--- /dev/null<br>
+++ b/meta/recipes-core/expat/expat/0002-expat-Added-support-for-ptests-in-form-of-new-target.patch<br>
@@ -0,0 +1,31 @@<br>
+From 2b209a025f62fb1be7b32599aa80703ce8ecd76a Mon Sep 17 00:00:00 2001<br>
+From: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+Date: Thu, 6 Feb 2020 13:43:57 +0200<br>
+Subject: [PATCH 2/3] expat: Added support for ptests in form of new target<br>
+<br>
+<a href="http://configure.am" rel="noreferrer" target="_blank">configure.am</a> file changed, according to this advice:<br>
+<a href="https://wiki.yoctoproject.org/wiki/Ptest#Building_the_test_suite" rel="noreferrer" target="_blank">https://wiki.yoctoproject.org/wiki/Ptest#Building_the_test_suite</a><br>
+<br>
+Signed-off-by: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+---<br>
+ <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 4 ++--<br>
+ 1 file changed, 2 insertions(+), 2 deletions(-)<br>
+<br>
+diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+index d58ac03..8e6b41e 100644<br>
+--- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
++++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+@@ -34,8 +34,8 @@ AC_CONFIG_SRCDIR([Makefile.in])<br>
+ AC_CONFIG_AUX_DIR([conftools])<br>
+ AC_CONFIG_MACRO_DIR([m4])<br>
+ AC_CANONICAL_HOST<br>
+-AM_INIT_AUTOMAKE<br>
+-<br>
++AM_INIT_AUTOMAKE([serial-tests])<br>
++AM_EXTRA_RECURSIVE_TARGETS([buildtest-TESTS])<br>
+ <br>
+ dnl<br>
+ dnl Increment LIBREVISION if source code has changed at all<br>
+-- <br>
+2.17.1<br>
+<br>
diff --git a/meta/recipes-core/expat/expat/0003-expat-Added-suitable-format-of-tests-in-ptest.patch b/meta/recipes-core/expat/expat/0003-expat-Added-suitable-format-of-tests-in-ptest.patch<br>
new file mode 100644<br>
index 0000000000..5d1daefc92<br>
--- /dev/null<br>
+++ b/meta/recipes-core/expat/expat/0003-expat-Added-suitable-format-of-tests-in-ptest.patch<br>
@@ -0,0 +1,50 @@<br>
+From b2e236e238f8bab42651313ea198b27355945d97 Mon Sep 17 00:00:00 2001<br>
+From: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+Date: Thu, 6 Feb 2020 13:44:56 +0200<br>
+Subject: [PATCH 3/3] expat: Added suitable format of tests in ptest<br>
+<br>
+Some changes in testcases code were applied for testcase engine.<br>
+This was just adding of message outputs in "RESULT: TESTNAME" form...<br>
+<br>
+Signed-off-by: Oleksandr Popovych <<a href="mailto:oleksandr.s.popovych@globallogic.com" target="_blank">oleksandr.s.popovych@globallogic.com</a>><br>
+---<br>
+ tests/minicheck.c | 4 ++++<br>
+ 1 file changed, 4 insertions(+)<br>
+<br>
+diff --git a/tests/minicheck.c b/tests/minicheck.c<br>
+index a5a1efb..b39cda9 100644<br>
+--- a/tests/minicheck.c<br>
++++ b/tests/minicheck.c<br>
+@@ -164,6 +164,7 @@ srunner_run_all(SRunner *runner, int verbosity) {<br>
+ if (tc->setup != NULL) {<br>
+ /* setup */<br>
+ if (setjmp(env)) {<br>
++ printf("SKIP: %s\n", _check_current_function);<br>
+ add_failure(runner, verbosity);<br>
+ continue;<br>
+ }<br>
+@@ -171,6 +172,7 @@ srunner_run_all(SRunner *runner, int verbosity) {<br>
+ }<br>
+ /* test */<br>
+ if (setjmp(env)) {<br>
++ printf("FAIL: %s\n", _check_current_function);<br>
+ add_failure(runner, verbosity);<br>
+ continue;<br>
+ }<br>
+@@ -179,11 +181,13 @@ srunner_run_all(SRunner *runner, int verbosity) {<br>
+ /* teardown */<br>
+ if (tc->teardown != NULL) {<br>
+ if (setjmp(env)) {<br>
++ printf("PASS: %s\n", _check_current_function);<br>
+ add_failure(runner, verbosity);<br>
+ continue;<br>
+ }<br>
+ tc->teardown();<br>
+ }<br>
++ printf("PASS: %s\n", _check_current_function);<br>
+ }<br>
+ tc = tc->next_tcase;<br>
+ }<br>
+-- <br>
+2.17.1<br>
+<br>
diff --git a/meta/recipes-core/expat/expat/run-ptest b/meta/recipes-core/expat/expat/run-ptest<br>
new file mode 100644<br>
index 0000000000..df994c0838<br>
--- /dev/null<br>
+++ b/meta/recipes-core/expat/expat/run-ptest<br>
@@ -0,0 +1,3 @@<br>
+#!/bin/bash<br>
+<br>
+make -k runtests<br>
diff --git a/meta/recipes-core/expat/<a href="http://expat_2.2.9.bb" rel="noreferrer" target="_blank">expat_2.2.9.bb</a> b/meta/recipes-core/expat/<a href="http://expat_2.2.9.bb" rel="noreferrer" target="_blank">expat_2.2.9.bb</a><br>
index 8f3db41352..420ffddc80 100644<br>
--- a/meta/recipes-core/expat/<a href="http://expat_2.2.9.bb" rel="noreferrer" target="_blank">expat_2.2.9.bb</a><br>
+++ b/meta/recipes-core/expat/<a href="http://expat_2.2.9.bb" rel="noreferrer" target="_blank">expat_2.2.9.bb</a><br>
@@ -8,15 +8,25 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=5b8620d98e49772d95fc1d291c26aa79"<br>
<br>
SRC_URI = "${SOURCEFORGE_MIRROR}/expat/expat-${PV}.tar.bz2 \<br>
file://libtool-tag.patch \<br>
+ file://0001-expat-Added-Makefile-targets-for-ptest-support.patch \<br>
+ file://0002-expat-Added-support-for-ptests-in-form-of-new-target.patch \<br>
+ file://0003-expat-Added-suitable-format-of-tests-in-ptest.patch \<br>
+ file://run-ptest \<br>
"<br>
<br>
SRC_URI[md5sum] = "875a2c2ff3e8eb9e5a5cd62db2033ab5"<br>
SRC_URI[sha256sum] = "f1063084dc4302a427dabcca499c8312b3a32a29b7d2506653ecc8f950a9a237"<br>
<br>
-inherit autotools lib_package<br>
+inherit autotools ptest lib_package<br>
+<br>
+RDEPENDS_${PN}-ptest += "make bash"<br>
<br>
do_configure_prepend () {<br>
rm -f ${S}/conftools/libtool.m4<br>
}<br>
<br>
+do_compile_ptest() {<br>
+ oe_runmake buildtest-TESTS<br>
+}<br>
+<br>
BBCLASSEXTEND = "native nativesdk"<br>
-- <br>
2.17.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div>