[oe] [oe-commits] org.oe.dev Add cryptsetup: Stop forcing your opinions onto other people!

[Matthias Hentges]

(due to the retarded ML server, this message may appear twice)

For starters, this mailing list is still broken and violates RFCs in
regards to FROM and REPLY-TO.

Am Dienstag, den 20.11.2007, 22:03 +0100 schrieb Koen Kooi:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> coredump2 commit schreef:
> 
> 
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> > +######################################################################################
> 
> Please read (and follow) the styleguide and run the recipe through
> OE-stylize.py to get an idea how it should look like.

Nice "style". With my layout, you at least had a sense about what does
what, the entries were grouped for easy reading.

Your "style" does nothing more than remove any kind of possible grouping
by deleting linefeeds left and right. Your "style" stinks.


> > +pkg_postinst() {
> > +	if test "x$D" = "x"
> > +	then 
> > +		# Work around a problem in module ipk's, where depmod is not always
> > +		# run after installing a kernel-module.
> > +		test -x /sbin/depmod && /sbin/depmod -a
> > +		/bin/true
> > +	fi
> 
> And don't add such hacks, please remove it.
> 

The "hack" had a very valid purpose. I even explained the purpose for
you alone in the .bb. It worked around a very real bug in module
handling which no one (not even you) bothered to fix for > 1 year.
A bug which is *impossible* to track-down or fix for most end-users.

Would be PLEASE STOP MESSING WITH OTHER PEOPLES FILES??
Only because YOU do not like something does NOT give you the bloody
right to revert or even change other peoples commits!

THIS IS NOT KOEN-EMBEDDED
-- 
Matthias 'CoreDump' Hentges 
Cologne / Germany

Webmaster of Hentges.net & Embedded Linux Developer
GPG ->  gpg --keyserver gpg-keyserver.de --recv-keys 0xAF3030D9

My OS: Debian SID: Geek by Nature, Linux by Choice