[oe] openmoko-merges

[John Lee]

On Thu, Dec 18, 2008 at 07:05:51PM +0100, Koen Kooi wrote:
> On 18-12-08 17:54, Phil Blundell wrote:
>> On Thu, 2008-12-18 at 16:24 +0100, Koen Kooi wrote:
>>> On 18-12-08 16:05, John Lee wrote:
>>>> Okay, here is what I will do:
>>>>
>>>> 1) commit zero controversial part into oe.dev first.
>>> You don't know if it's controversial or not without it being reviewed.
>>> So no, don't commit stuff.
>>
>> Is there now a policy of requiring review and pre-approval for all
>> checkins to the tree?  If so, when was this instigated?  I haven't
>> noticed any discussion of that and I would not be in favour of any such
>> change.
>
> No policy for checkins per se, but for merging commits for large  
> branches. In this case, a review was requested and the response was to  
> *not* commit anything.
> Asking for a review and then saying "I'll be the judge of things" is a  
> bit backwards.
> The coreteam will make a statement about merging branches soonish.
>


Something in the om.dev are quite normal just like other commits in
oe.dev tree, such as changing sane-srcrev, adding checksum, recipes,
fixes, etc.  I doubt these need to be reviewed along with the whole
branch. (well, I realize it's me who put them there in the first
place... :p )

I'll keep working on the fastboot branch (need the help of original
author on this one.  since this will become general changes, it's not
going to be easy), and reorganize the om-merge branch a bit.  Is this
the first time of such a big merge ?  I think Graeme and I both did
some merge back before, but this one seems to be bigger...


- John