[oe] [RFC] A case of distro config overriding DISTRO var

[Paul Sokolovsky]

Hello,

On Sat, 09 Feb 2008 19:04:33 +0000
Richard Purdie <rpurdie at rpsys.net> wrote:

> 
> On Sat, 2008-02-09 at 21:04 +0200, Paul Sokolovsky wrote:
> > On Sat, 09 Feb 2008 18:42:49 +0000
> > Richard Purdie <rpurdie at rpsys.net> wrote:
> > > On Sat, 2008-02-09 at 11:56 +0200, Paul Sokolovsky wrote:
> > > > ============================================================
> > > > --- classes/image.bbclass
> > > > 4d92381733b09bae07a07da35bd0024744924c3c +++
> > > > classes/image.bbclass
> > > > 6eeae6a01c36465bc36cc737d42ea6b8ab09b152 @@ -90,6 +90,7 @@
> > > > fakeroot do_rootfs () { ${IMAGE_PREPROCESS_COMMAND} 
> > > >  	export TOPDIR=${TOPDIR}
> > > > +	export DISTRO=${USERDISTRO}
> > > >  	export MACHINE=${MACHINE}
> > > 
> > > This could be rather confusing, can we not have:
> > > 
> > > USERDISTRO=${USERDISTRO}
> > > 
> > > then its obvious which variable we mean?
> > 
> > Not sure I understand. USERDISTRO is the variable which holds *real*
> > DISTRO value, and here, we just use that real value to set a
> > top-level parameter DISTRO for a tool which expects such top-level
> > parameter (bbimage in this case).
> 
> Can it not expect USERDISTRO though? Where exactly is this being used?
> 
> I just worry that people are going to get confused if we call this
> DISTRO since its not the value in the "DISTRO" variable...

Well, it *is* value of DISTRO variable. Secondly, how you imagine that
- bitbake accepts some notion as DISTRO variable, yet bbimage as
USERDISTRO variable? And people should not be confused or even
concerned with all this stuff - it's just internal OE workings made to
make external whitebox interface (DISTRO being a part of it) work as
it should.

Well, after all, bitbake is your area. Pragmatically, I of course would 
prefer to avoid waiting for next bitbake release to get this right
though. Ah, and why bbimage needs DISTRO set properly? It just loads
bitbake.conf and that references ${DISTRO}.conf.

> 
> Cheers,
> 
> Richard
> 
> 
> 



-- 
Best regards,
 Paul                          mailto:pmiscml at gmail.com