[oe] Uppercase overrides and parsing speed

Richard Purdie rpurdie at rpsys.net
Sat Feb 23 19:04:17 UTC 2008


Hi,

At OEDEM I mentioned that we might have some speed gain if bitbake could
more easily tell what constituted an override. All current overrides are
lower case and we don't have any in upper case. I tried having bitbake
ignore uppercase overrides (things like URI in SRC_URI) and saw a 2.5%
increase in parsing speed. A patch for bitbake is appended in case
anyone wishes to experiment.

Note it doesn't 100% disambiguate the situation since we have lowercase
variables.

Cheers,

Richard


Index: lib/bb/data_smart.py
===================================================================
--- lib/bb/data_smart.py	(revision 1010)
+++ lib/bb/data_smart.py	(working copy)
@@ -156,9 +156,10 @@
         # more cookies for the cookie monster
         if '_' in var:
             override = var[var.rfind('_')+1:]
-            if not self._seen_overrides.has_key(override):
-                self._seen_overrides[override] = Set()
-            self._seen_overrides[override].add( var )
+            if not override.isupper():
+                if not self._seen_overrides.has_key(override):
+                    self._seen_overrides[override] = Set()
+                self._seen_overrides[override].add( var )
 
         # setting var
         self.dict[var]["content"] = value





More information about the Openembedded-devel mailing list