[oe] liboil softfloat fix questions

[Henning Heinold]

On Thu, Sep 25, 2008 at 09:31:43AM +0200, Koen Kooi wrote:
> Hi,
>
> I noticed liboil got patched:
>
> +if test x"${ENABLE_SOFTFLOAT}" = "xyes"; then
> +      VFP_CFLAGS="$VFP_CFLAGS -mfloat-abi=softfp"
> +else
> +      VFP_CFLAGS="$VFP_CFLAGS -mfpu=vfp"
>
> That looks a bit wrong to me, since for EABI you'd want  
> '-mfloat-abi=softfp -mfpu=vfp' to make it use the VFP coprocessor using  
> softfloat calling conventions[1] and plain '-mfloat-abi=softfp' to do  
> softfloat, and with OABI you don't want to pass '-mfloat-abi=softfp'
> To make it even more complicated, on armv7a[2] you want to pass  
> -mfpu=neon -mfloat-abi=softfp. If you look at the output of gcc -S  
> you'll see that EABI won't use an FPU unless you pass in  
> -mfloat-abi=softfp *and* -mfpu=<FPU>.
>
> AFAICT OE passes all the needed magic already in TARGET_CCFLAGS, so it  
> seems that this entire construct can be removed.
>
> Robert, could you beat the cacao people with a cluebat so they get their  
> stuff right?

Hi,

okay seems I have to learn more about fpu stuff.

>From cacao I only took the configure option. The Cflags comes from
liboil itself.

I will remove this cruft from the configure.ac and will try again.

Bye Henning