[oe] [STABLE][PATCH v2] mingw-binutils: update to 2.19.1

[Esben Haabendal]

On Tue, Apr 7, 2009 at 6:51 PM, Tom Rini <trini at kernel.crashing.org> wrote:
> On Tue, Apr 07, 2009 at 09:16:28AM +0200, Esben Haabendal wrote:
>
> [snip]
>> +[http://downloads.sourceforge.net/mingw/binutils-2.19.1-src.tar.gz]
>> +md5=ad3f2b5fdcd599a772ad75fec2c384d8
>> +sha256=2df529b1ac0a621efb87b5b53dbc0167c566f8bebbd6a8ce19964b05845fd2e7
>
> You need to run the 'contrib/source-checker/oe-checksums-sorter.py'
> after adding a new checksum.  Roughly
> /contrib/source-checker/oe-checksums-sorter.py conf/checksums.ini > t &&
> mv t conf/checksums.ini.

Ok.

>> diff --git a/recipes/binutils/mingw-binutils-canadian-cross_2.19.1.bb
>> b/recipes/binutils/mingw-binutils-canadian-cross_2.19.1.bb
>> new file mode 100644
>> index 0000000..130dea5
>> --- /dev/null
>> +++ b/recipes/binutils/mingw-binutils-canadian-cross_2.19.1.bb
>> @@ -0,0 +1,10 @@
>> +require mingw-binutils_${PV}.bb
>> +require binutils-canadian-cross.inc
>> +
>> +DEFAULT_PREFERENCE_sdk-mingw32 = "1"
>
> This should just be DEFAULT_PREFERENCE_mingw32 = "1".  Or just left out
> as we aren't setting this to -1 for anything else.

Well, as you suggest later on, I have now set DEFAULT_PREFERENCE to
-1, so I will be keeping in this, but of-course using _mingw32 instead
of the (now) defunct _sdk-mingw32

>> diff --git a/recipes/binutils/mingw-binutils_2.19.1.bb
>> b/recipes/binutils/mingw-binutils_2.19.1.bb
>> new file mode 100644
>> index 0000000..19d1077
>> --- /dev/null
>> +++ b/recipes/binutils/mingw-binutils_2.19.1.bb
>> @@ -0,0 +1,12 @@
>> +PR = "r1"
>
> First PR should be r0, and the PR line left out in this case.

Ok, I failed to find any information on this earlier.

So I just decided, based on what I think would make sense, that the first
version shoul dbe r1, and r0 being left as an indication that no PR
were set.

> This also
> looks a whole lot like the older one, so perhaps the best thing to do
> here would be to rename the old one to mingw-binutils.inc and just
> include that in mingw-binutils_version.bb (which iirc does need to
> exist).

Well, it looks a lot like, but is not identical.
But I've created a common mingw-binutils.inc, and require'd this by the two
mingw-binutils_version.bb files.

>> +DEFAULT_PREFERENCE = "0"
>
> Then drop this, or set to -1.  I forget off the top of my head if
> something will go wrong and try and use this for non-canadian stuff if
> we don't have a -1 here..

I will not guarantee that that it won't go wrong and use this for anything
else than MinGW canadian stuff, and as such, it seems really silly
to risk fucking up things just to save a few bytes in a recipe.

> Finally, the way Stable works, as I read it, is that the patch goes into
> dev first then stable.  Not at the same time.

Ok.

Then, please someone apply this to .dev.  But then how are we supposed
to remember which patches should also be moved to stable, and when?

Let's not make it to complicated to maintain stable, so that it will die
from us again :-(

Of-course, this approach will not work generally, as .dev will and must
diverge from stable, and more and more fixes will be specific to stable.

/Esben