[oe] [PATCH] gcc_4.2.4.bb: QA Issue: No GNU_HASH in theelf binary

[Tom Rini]

On Wed, Apr 29, 2009 at 06:26:15PM +0200, Stanislav Brabec wrote:
> Tom Rini wrote: 
> > On Wed, Apr 29, 2009 at 08:21:15AM -0400, Philip Balister wrote:
> > > Sledz, Steffen wrote:
> 
> > >> Fix works for me. But it would be nice if some members of the core team could ack it.
> > >
> > > Does anyone see any downside for this patch? Have other people tested  
> > > it? I hate blind acking things.
> > 
> > Khem has a patch for this issue too but wants to test it more.
> 
> I just tested another way to fix. It looks like a gcc bug - LDFLAGS nor
> LDFLAGS_FOR_TARGET are not used in gcc/Makefile.
> 
> diff --git a/recipes/gcc/gcc-configure-common.inc b/recipes/gcc/gcc-configure-common.inc
> index e88cee5..9ede6a2 100644
> --- a/recipes/gcc/gcc-configure-common.inc
> +++ b/recipes/gcc/gcc-configure-common.inc
> @@ -73,7 +73,18 @@ do_configure () {
>  	export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}"
>  	export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}"
>  	export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}"
>  	export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}"
> +	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in ${S}/Makefile.tpl
>  	(cd ${S} && gnu-configize) || die "failure running gnu-configize"
>  
>  	# splice our idea of where the headers live into gcc's world

Based on this, I've got a patch mostly ready to go, tomorrow.  Building
fine for gcc-* are;
- 4.1.1, 4.1.2, 4.2.[234], 4.3.[123] and 4.4.0
I've got some other changes done so that 4.1.0, 4.0.0 and 4.0.2 build or
mostly build.  For 4.1.0 I had to point it at 4.1.1's patches as there's
no 4.1.0 patch directory.  For 4.0.x I've had to pull in the posix
open() fixup from 3.x (and I've renamed and moved to files/) and pass in
--disable-libmudflap.  All of these also won't build on x86_64 so I've
dropped down to a 32bit chroot for these in particular.  I've patched
but haven't tried yet, 3.3.x / 3.4.x.

This also drops the incomplete in many cases and no longer needed
ldflags.patch as well.

The above has distracted me a bit from trying the canadian-sdk stuff but
I will before pushing this.

-- 
Tom Rini