[oe] Commit 2e0fa4918d643ce6ec0299cd31cfe1c346e4bce3 breaks libtool's do_configure [PATCH]

[Mike Westerhof]

Stanislav Brabec wrote:
> Marc Olzheim wrote:
>> I'm not sure how you tested this, but there are quotes missing, so that
>> the "-E" argument to "grep" is passed to "export" instead. I guess some
>> shells have a "-E" flag to "export", so it is silently ignored, but mine
>> don't.
> 
> I tried both versions - quoted and unquoted - before the commit. Both
> worked for me, that is why I committed the shorter one.
> 
> Well, adding quotes is safe. Can you check your configure output and
> host shell version?
> 
> My configure output:
> 
> checking for a sed that does not truncate output... (cached) /bin/sed
> checking for grep that handles long lines and -e... (cached) /bin/sed
> checking for egrep... (cached) /bin/grep -E
> checking for fgrep... (cached) /bin/grep -F
> 
> It indicates, that it worked correctly.
> 
> My native shell is:
> 
> /OE/openembedded/build> sh --version
> GNU bash, version 4.0.24(1)-release (x86_64-suse-linux-gnu)
> 

The original commit seems to break libltdl.so as well (which was not
fixed by the subsequent patch to add quotes).  Libtool builds, but
certain dependencies fail.  Host platforms affected include Fedora and
Ubuntu, and neither uses dash.

Failing packages fail in do_configure, with a missing symbol in libltdl:
logs from the nslu2 autobuilder are up on tinderbox:

http://tinderbox.openembedded.net/public/logs/task/2207578.txt

Here's the message in config.log from that build:

configure:16081: checking for lt_dlinit in -lltdl
configure:16116: arm-linux-gnueabi-gcc -march=armv5te -mtune=xscale
-mno-thumb-interwork -mno-thumb -mno-thumb-interwork -mno-thumb -o
conftest
-isystem/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/include
-fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os
-Wall -Wmissing-declarations -Wmissing-prototypes
-isystem/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/include
-I$(top_srcdir) -I$(top_builddir) -I$(top_srcdir)/libgphoto2_port
-I$(top_srcdir)/libgphoto2 -I$(top_builddir)/libgphoto2
-isystem/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/include
-Wall -g -D_GPHOTO2_INTERNAL_CODE
-L/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/lib
-Wl,-rpath-link,/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/lib
-Wl,-O1 -Wl,--hash-style=gnu conftest.c -lltdl   >&5
/home/slug/slugos/tmp/staging/armv5te-linux-gnueabi/usr/lib/libltdl.so:
undefined reference to `lt_libltdl_LTX_preloaded_symbols'
collect2: ld returned 1 exit status
configure:16122: $? = 1


Mike (mwester)