[oe] [PATCH] kernel.bbclass: stage more include files for x86 in 2.6.27+

Michael Smith msmith at cbnco.com
Fri Aug 21 12:47:20 UTC 2009


On Fri, 21 Aug 2009, Roman I Khimov wrote:

>> OK to commit?
>>> -	rm -f $ASMDIR ${STAGING_KERNEL_DIR}/include/asm
>>> +
>>> +	rm -f ${STAGING_KERNEL_DIR}/include/asm

> Not sure why this is needed

$ASMDIR is a directory name like "asm-x86" meant to be relative to 
"include". It doesn't exist under the work directory, so "rm -f $ASMDIR" 
tries to remove a file that isn't there. Doesn't hurt anything, but I had 
to stare at it for a bit, so I took it out. :)

> though you copy to asm-x86 and mine was to $ASMDIR:
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2009-June/011945.html

Yeah, I think in your patch you did:

cp -fR arch/x86/include/asm/* ${STAGING_KERNEL_DIR}/include/$ASMDIR/

But on another platform, let's say arm, wouldn't that copy 
arch/x86/include/* to include/asm-arm? The x86 files should only go to 
asm-x86.

Mike




More information about the Openembedded-devel mailing list