[oe] [PATCH] sane-toolchain-eglibc.inc: Set TARGET_OS = linux-gnuspe for e500

[Khem Raj]

On Sat, Aug 29, 2009 at 1:14 AM, Phil Blundell<philb at gnu.org> wrote:
> On Fri, 2009-08-28 at 17:00 -0700, Khem Raj wrote:
>> Target triplet powerpc-*-linux-gnuspe is chosen for machines with SPE
>> which is e500 cores.
>>
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>>  conf/distro/include/sane-toolchain-eglibc.inc |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/conf/distro/include/sane-toolchain-eglibc.inc b/conf/distro/include/sane-toolchain-eglibc.inc
>> index 88719f5..6b66679 100644
>> --- a/conf/distro/include/sane-toolchain-eglibc.inc
>> +++ b/conf/distro/include/sane-toolchain-eglibc.inc
>> @@ -5,6 +5,8 @@
>>
>>  TARGET_OS = "linux${@['','-gnueabi'][bb.data.getVar('TARGET_ARCH',d,1) in ['arm', 'armeb'] and bb.data.getVar('MACHINE',d) not in ['collie','h3600', 'h3800', 'simpad', 'htcwallaby']]}"
>>
>> +TARGET_OS = "linux${@['','-gnuspe'][bb.data.getVar('TARGET_ARCH',d,1) in ['ppc', 'powerpc'] and bb.data.getVar('MACHINE',d) in ['calamari', 'tqm8540']]}"
>> +
>
> This change looks like it will break the -gnueabi thing on ARM, which
> presumably isn't intended.

yes indeed see my previous reply
>
> Also, is this really specific to eglibc?  Per our conversation on IRC
> the other day, I kind of feel that this sort of logic belongs somewhere
> else; it seems somewhat inappropriate for sane-toolchain-xx.inc to be
> frobbing fundamental variables like TARGET_OS in this way.

TARGET_OS is really equivalent of TARGET_TRIPLET here and it is tied
to system C library you choose.
so logically it seems ok to me. You can also define it in distro confs but then
you have to check like if LIBC == uclibc do one thing  else LIBC =
glibc do other thing

Thx

-Khem

>

> p.
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>