[oe] [PATCH] sane-toolchain-eglibc.inc: Set TARGET_OS = linux-gnuspe for e500

[Phil Blundell]

On Sun, 2009-08-30 at 02:22 -0700, Khem Raj wrote:
> based upon your idea in last email. Here is something I put together
> seems to work. It will need testing ofcourse
> 
> What do you think about this one ?

Thanks for the update.  This looks like generally the right idea, except
that I still feel it is undesirable for an innocuous-looking change of
MACHINE to result in far-reaching abi consequences.  So we need to
figure out a way to deal with that.

A few other specific comments about the patch:

> +python detect_arm_abi () {

This doesn't really need to be an OE function.  You can declare it
directly as Python:

def detect_arm_abi():

> +       if bb.data.getVar("TARGET_ARCH", d, 1) in [ 'arm', 'armeb' ]:          
> +               if bb.data.getVar('MACHINE',d) in ['collie','h3600', 'h3800', 'simpad', 'htcwallaby']:
> +                       return "oabi"
> +               return "eabi"
> +       else
> +               return ""

Notwithstanding the thing about MACHINE that I mentioned above, this
logic doesn't really look like it can be correct.  There are only two
valid ARM ABIs: eabi and oabi, and I would have thought this function
should always pick one or the other.  In other words, I don't think that
returning "" should be a valid result.

> +       if bb.data.getVar('TARGET_ARCH',d,1) in ['bfin']:
> +               os_suffix = "uclinux"
> +       else
> +               os_suffix = "linux"

I'm not terribly convinced that this is desirable; TARGET_OS itself has
always been a primary user configuration variable and I'm not entirely
comfortable with making it be an auto-guessed thing.  I'm also not very
keen on doing anything to cement the perception that OE is, somehow,
only for Linux targets.  But I guess I am open to persuasion on this
one.

p.