[oe] [PATCH 5/6] sun-jre6: add 1.6.0.10

Otavio Salvador otavio at debian.org
Thu Feb 12 23:48:45 UTC 2009


Koen Kooi <k.kooi at student.utwente.nl> writes:

> On 12-02-09 17:38, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador<otavio at ossystems.com.br>
>> ---
>
> NACK:
>
>> +PACKAGES =+ "${PN}-plugin"
>> +
>> +FILES_${PN} = "/usr/"
>> +FILES_${PN}-dbg += "/usr/*/.debug /usr/*/*/.debug /usr/*/*/*/.debug /usr/*/*/*/*/.debug /usr/*/*/*/*/*/.debug"
>> +FILES_${PN}-plugin = "${libdir}/firefox-3.0.1/plugins/* ${libdir}/sun-java6-${PV}/plugin/i386/ns7/libjavaplugin_oji.so"
>
> it would be better to install the plugin to /usr/lib/mozilla/plugins
> and have a postinst that symlinks it to ${libdir}/firefox-*,
> ${libdir}/fennec-*, ${libdir}/iceweasle when those are present. That
> way other browser implement NPAPI (webkit...) can use the one in
> mozilla/plugins.

I've not added the symbolic links since it is quite easy to make firefox
to use that dir. In fact, it has already been done at
d09c754ec52a3f09f1cad6a34d12b9ef7283bc17 and can be done for others I
think.

I've fixed the style issues and the plugin installation as you've
spot. Please check and ack if it is all OK.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sun-jre6-add-1.6.0.10.patch
Type: text/x-diff
Size: 3359 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20090212/3a91ac5f/attachment-0005.bin>
-------------- next part --------------


-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."


More information about the Openembedded-devel mailing list