[oe] [PATCH] remove duplicated code from linux.inc
Graeme Gregory
dp at xora.org.uk
Fri Jul 31 07:12:03 UTC 2009
Graham Gower wrote:
> Graeme Gregory wrote:
>> Why dont you prepend it to the current uImage creation code running
>> only conditionally on UBOOT_ENTRYSYMBOL being set? As its in the same
>> bit of shell code your resetting of UBOOT_ENTRYPOINT will take
>> precedence! Also means other machines can use it.
>
> Once I realised that ${FOO} is replaced before the shell function is run,
> while $FOO is not, things made a lot more sense.
>
> Allow a dynamic entry point via UBOOT_ENTRYSYMBOL and remove redundant
> uboot-mkimage code in kernel.bbclass.
>
Looks good to me, do you fancy moving that do_compile_append into
kernel.bbclass? You can then have the added kudos of fixing OE core
files :-)
Graeme
More information about the Openembedded-devel
mailing list