[oe] [PATCH] locality of python{} variables (was e2fsprogs-libs is unbuildable for .dev)

[Ihar Hrachyshka]

Problem is still there (built today from scratch).

On Mon, May 25, 2009 at 8:18 PM, Stanislav Brabec <utx at penguin.cz> wrote:
> Denys Dmytriyenko wrote:
>> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=61f0ac5601f6c03871d084f879ef618664d9b2c6
>
> Blindly guessing that variables inside python statement may be global. I
> see no other explanation, how variables can get a value defined in
> another .bb file.
>
> Here is a partial fix (just a variable rename) that allowed to continue
> the build. If my guess is true, then possible problems of
> do_split_packages() may be pretty widespread.
>
> diff --git a/recipes/e2fsprogs-libs/e2fsprogs-libs.inc b/recipes/e2fsprogs-libs/e2fsprogs-libs.inc
> index 8b214c1..5b82c11 100644
> --- a/recipes/e2fsprogs-libs/e2fsprogs-libs.inc
> +++ b/recipes/e2fsprogs-libs/e2fsprogs-libs.inc
> @@ -15,12 +15,12 @@ FILES_e2fsprogs-libs-dev_append = " ${datadir}/et ${datadir}/ss"
>  FILES_${PN} = "${bindir}"
>
>  python populate_packages_prepend () {
> -       cv_libdir = bb.data.expand('${libdir}', d)
> -       cv_libdir_dbg = bb.data.expand('${libdir}/.debug', d)
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.so$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev', allow_links=True)
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.la$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev')
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.a$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev')
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.so\.*', 'lib%s', 'e2fsprogs-libs %s library', extra_depends='', allow_links=True)
> +       e2fs_libdir = bb.data.expand('${libdir}', d)
> +       e2fs_libdir_dbg = bb.data.expand('${libdir}/.debug', d)
> +       do_split_packages(d, e2fs_libdir, '^lib(.*)\.so$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev', allow_links=True)
> +       do_split_packages(d, e2fs_libdir, '^lib(.*)\.la$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev')
> +       do_split_packages(d, e2fs_libdir, '^lib(.*)\.a$', 'lib%s-dev', 'e2fsprogs-libs %s development package', extra_depends='${PN}-dev')
> +       do_split_packages(d, e2fs_libdir, '^lib(.*)\.so\.*', 'lib%s', 'e2fsprogs-libs %s library', extra_depends='', allow_links=True)
>  }
>
>  do_stage () {
> diff --git a/recipes/util-linux-ng/util-linux-ng.inc b/recipes/util-linux-ng/util-linux-ng.inc
> index 45fd1a6..9c70b9e 100644
> --- a/recipes/util-linux-ng/util-linux-ng.inc
> +++ b/recipes/util-linux-ng/util-linux-ng.inc
> @@ -123,12 +123,12 @@ do_install () {
>  }
>
>  python populate_packages_prepend () {
> -       cv_libdir = bb.data.expand('${libdir}', d)
> -       cv_libdir_dbg = bb.data.expand('${libdir}/.debug', d)
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.so$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev', allow_links=True)
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.la$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev')
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.a$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev')
> -       do_split_packages(d, cv_libdir, '^lib(.*)\.so\.*', 'lib%s', 'util-linux-ng %s library', extra_depends='', allow_links=True)
> +       ulinxng_libdir = bb.data.expand('${libdir}', d)
> +       ulinxng_libdir_dbg = bb.data.expand('${libdir}/.debug', d)
> +       do_split_packages(d, ulinxng_libdir, '^lib(.*)\.so$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev', allow_links=True)
> +       do_split_packages(d, ulinxng_libdir, '^lib(.*)\.la$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev')
> +       do_split_packages(d, ulinxng_libdir, '^lib(.*)\.a$', 'lib%s-dev', 'util-linux-ng %s development package', extra_depends='${PN}-dev')
> +       do_split_packages(d, ulinxng_libdir, '^lib(.*)\.so\.*', 'lib%s', 'util-linux-ng %s library', extra_depends='', allow_links=True)
>  }
>
>
>
> --
> Stanislav Brabec
> http://www.penguin.cz/~utx/zaurus
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>