[oe] [PATCH 06/12] meta-toolchain-qte: initial qt embedded toolchain version

[Tom Rini]

On Fri, Jun 05, 2009 at 08:35:56PM +0300, Ihar Hrachyshka wrote:
> On Fri, Jun 5, 2009 at 6:45 PM, Tom Rini<trini at embeddedalley.com> wrote:
> > On Fri, Jun 05, 2009 at 11:47:04AM +0300, Ihar Hrachyshka wrote:
> >> On Wed, Jun 3, 2009 at 7:04 PM, Tom Rini<trini at embeddedalley.com> wrote:
> >> > On Wed, Jun 03, 2009 at 06:37:16PM +0300, Ihar Hrachyshka wrote:
> >> >
> >> >> +do_populate_sdk_append() {
> >> >> +       script = "${SDK_OUTPUT}/${prefix}/environment-setup"
> >> >> +       touch $script
> >> >> +       echo 'export OE_QMAKE_CC=${TARGET_SYS}-gcc' >> $script
> >> >> +       echo 'export OE_QMAKE_CXX=${TARGET_SYS}-g++' >> $script
> >> >> +       echo 'export OE_QMAKE_LINK=${TARGET_SYS}-g++' >> $script
> >> >> +       echo 'export OE_QMAKE_LIBDIR_QT=${prefix}/${TARGET_SYS}/${layout_libdir}' >> $script
> >> >> +       echo 'export OE_QMAKE_INCDIR_QT=${prefix}/${TARGET_SYS}/${layout_includedir}/${QT_DIR_NAME}' >> $script
> >> >> +       echo 'export OE_QMAKE_MOC=${prefix}/${layout_bindir}/moc4' >> $script
> >> >> +       echo 'export OE_QMAKE_UIC=${prefix}/${layout_bindir}/uic4' >> $script
> >> >> +
> >> >> +       # Repack SDK with new environment-setup
> >> >> +       cd ${SDK_OUTPUT}
> >> >> +       fakeroot tar cfj ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.tar.bz2 .
> >> >> +}
> >> >
> >> > I see two minor problems.  First, environment-setup is going to exist so
> >> > we don't need to touch it again.  In fact, the variable should still be
> >> > set, but for clarity we should just comment (in case the file gets
> >> > renamed to say environment-setup.sh (if we add in a *csh style one
> >> > too)).  Second, we should update, not recreate the tarball (tar -jf ...
> >> > --add-file=${prefix}/environment-setup, I think).
> >>
> >> 1) Touching existing file is not a problem.
> >
> > But changing the name (for say once my *csh using cowork or customer
> > bugs me about it) will break here.
> 
> Sorry, but I don't get your point... Please explain me.

I've gone back and forth with myself on this.  My point is that it's a
little fragile, if ${SDK_OUTPUT}/${prefix}/environment-setup is renamed
(it's bash/etc-centric and for example, if my tcsh using coworker bugs
me, or a customer asks, I'll certainly make a
${SDK_OUTPUT}/${prefix}/environment-setup.csh and then push upstream,
and probably rename the old one to
${SDK_OUTPUT}/${prefix}/environment-setup.sh).  But, this isn't
happening right now, and well, even with my suggestion (using $script as
it's already set) would still be probably equally as fragile.

So, I'm happy with things as-is, sorry for the back-and-forth :)

-- 
Tom Rini