[oe] [PATCH] image.bbclass: remove tmp/rootfs after image creation unless you set a variable

Christopher Larson clarson at mvista.com
Wed Jun 17 19:11:33 UTC 2009


On Jun 17, 2009, at 12:07 PM, Leon Woestenberg wrote:

> Hello,
>
> On Wed, Jun 17, 2009 at 7:10 PM, Chris Larson<clarson at mvista.com>  
> wrote:
>> Set IMAGE_KEEPROOTFS to something other than the empty string to keep
>>
> +1 for the idea, but "something other than the empty string" is a very
> bad user interface.
>
>
> If users see:
>
> IMAGE_KEEPROOTFS = "1"
>
> in most cases they'll do:
>
> IMAGE_KEEPROOTFS = "0"
>
> instead of
>
> #IMAGE_KEEPROOTFS = "1"
>
>
> Do we have more of these?? It never occured to me before.


We have this sort of thing all over the place.  It needs an audit.   
Some vars expect set/empty, some expect 0/1, some expect yes/no, some  
just have a *convention* of yes/no.. afaik, anyway.
-- 
Chris Larson
Software Engineer
MontaVista Software, Inc.
Email: clarson AT mvista DOT com
Email: clarson AT kergoth DOT com





More information about the Openembedded-devel mailing list