[oe] [PATCH] image.bbclass: remove tmp/rootfs after image creation unless you set a variable

Chris Larson clarson at kergoth.com
Wed Jun 17 19:27:05 UTC 2009


On Wed, Jun 17, 2009 at 12:07 PM, Leon
Woestenberg<leon.woestenberg at gmail.com> wrote:
> Hello,
>
> On Wed, Jun 17, 2009 at 7:10 PM, Chris Larson<clarson at mvista.com> wrote:
>> Set IMAGE_KEEPROOTFS to something other than the empty string to keep
>>
> +1 for the idea, but "something other than the empty string" is a very
> bad user interface.
>
>
> If users see:
>
> IMAGE_KEEPROOTFS = "1"
>
> in most cases they'll do:
>
> IMAGE_KEEPROOTFS = "0"
>
> instead of
>
> #IMAGE_KEEPROOTFS = "1"
>
>
> Do we have more of these?? It never occured to me before.

Over the past day or so I've been thinking about putting together a
proof of concept variable type checking .inc.  Something like:

IMAGE_KEEPROOTFS ?= "0"
IMAGE_KEEPROOTFS[type] = "bool"

Then it would freak if it's not set to something valid for that type.
It wouldn't be hard to throw such a thing together.
-- 
Chris Larson
clarson at kergoth dot com
clarson at mvista dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Software Engineer
MontaVista Software, Inc.




More information about the Openembedded-devel mailing list