[oe] [PATCH 3/3] package_ipk: fix race in opkg.conf creation
Roman I Khimov
khimov at altell.ru
Thu Jun 18 08:49:20 UTC 2009
On Четверг 18 июня 2009 01:08:05 Tom Rini wrote:
> On Wed, Jun 17, 2009 at 11:42:00PM +0400, Roman I Khimov wrote:
> > It's a very little race, but one can hit it anyway on concurrent image
> > builds.
>
> So, the way this works is we do cp template ${IPKGCONF_TARGET} and use
> it, or so?
See package_generate_ipkg_conf in package_ipk.bbclass, it's echo-ing things in
destination files sequentially.
> And IPKGCONF_SDK / IPKGCONF_CANSDK won't race because we're
> cp'ing them to a final destination ?
I've thought that we're not doing multi-sdk, so it shouldn't be a problem.
Although if some build would need to do some images plus an SDK it might be
invoking package_generate_ipkg_conf from several places.
Maybe we can merge it with package_update_index_ipk (or just invoke
package_generate_ipkg_conf from there leaving the function itself)? Everything
except package-index meta-recipe does
package_update_index_ipk
package_generate_ipkg_conf
anyway.
More information about the Openembedded-devel
mailing list