[oe] fatal: Not a git repository

[pHilipp Zabel]

On Tue, Mar 3, 2009 at 6:54 AM, Douglas Royds <douglas.royds at tait.co.nz> wrote:
> Tom Rini wrote:
>>
>> On Tue, Mar 03, 2009 at 12:12:38AM +0000, Vitus Jensen wrote:
>>
>>>
>>> Am Mon, 02 Mar 2009 16:55:54 +1300 schrieb Douglas Royds:
>>>
>>>>
>>>> Anyone else getting this?
>>>>
>>>>    NOTE: Handling BitBake files: / (6587/6587) [100 %] NOTE: Parsing
>>>>    finished. 6302 cached, 0 parsed, 285 skipped, 0 masked. NOTE: Cache
>>>>    is clean, not saving.
>>>>    NOTE: build 200903021645: started
>>>>    fatal: Not a git repository <----------------------
>>>>
>>>>    OE Build Configuration:
>>>>    BB_VERSION        = "1.8.12"
>>>>    ...
>>>>
>>>
>>> Yes, it happens on every build.  I guess bitbake is testing the current
>>> directory via git and would include the current head in the build number.
>>>
>>>
>>>>
>>>> The same complaint seems to crop up at various points during a build, as
>>>> well.
>>>>
>>>> Suggestions?
>>>>
>>>
>>> Just ignore.  Besides called "fatal" it isn't fatal at all.
>>>
>>
>> Well, to git it's fatal :)  Someone should dig to where the call is and
>> redirect stderr somewhere, I suspect..
>>
>
> This silences it, though I'm not sure that it's the right solution:
>
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index 18afc1a..21b08a5 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -807,7 +807,7 @@ def base_get_metadata_svn_revision(d):
>
> def base_get_metadata_git_branch(d):
>       import os
> -       branch = os.popen('cd %s; git branch | grep "^* " | tr -d "* "' %
> base_get_scmbasepath(d)).read()
> +       branch = os.popen('cd %s; git branch 2>&1 | grep "^* " | tr -d "* "'
> % base_get_scmbasepath(d)).read()
>
>       if len(branch) != 0:
>               return branch

Maybe it should test whether
os.path.join(base_get_scmbasepath(d),'.git') exists before calling out
to git?

regards
Philipp