[oe] [oe-commits] Frans Meulenbroeks : opkg: fix bug that occured with file names of exactly 100 chars in the tar file

[Frans Meulenbroeks]

2009/3/3 Krzysztof Kotlenga <pocek at users.sf.net>:
>> Module: openembedded.git
>> Branch: org.openembedded.dev
>> Commit: 4e1b79d2d824ae7e0204251a09e852c24045c54a
>> URL:    http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=4e1b79d2d824ae7e0204251a09e852c24045c54a
>>
>> Author: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
>> Date:   Wed Feb 11 22:32:06 2009 +0100
>>
>> opkg: fix bug that occured with file names of exactly 100 chars in
>> the tar file
>>
>> ---
>>
>>  packages/opkg/files/opkg_unarchive.patch |   13 +++++++++++++
>
> Hi,
> this is actually a new bug, it causes paths in .list files being cut at
> 99 characters. I've run into this issue when I couldn't find gcc in
> meta-toolchain.
>
> --
> kjk
>

I don't have time today to look into this (all day & evening hooked up
at work). Probably tomorrow.
Anyway, appending the 0 byte is no good as tar_entry->name[100] is
already out of bounds.

For now I suggest undoing my patch. I'll come up with a better solution a.s.a.p.
Guess this needs to be fixed at the place where tar_entry->name is
used (the issue was that this array was 100 bytes and got followed by
the mode (.e.g 000644), so without my patch you got files like:
.....xml000644). this happens if the file name is exactly 100 chars

Apologies for any inconvenience.

Frans