[oe] I got the point - did everyone one else? [was: Re: [PATCH 70/70]...]

[Koen Kooi]

On 05-03-09 14:20, Mike (mwester) wrote:
> Koen Kooi wrote:
>> This is done so that patches get many eyes on them without people needed
>> to use git, and people wanting to test can do one of the following:
>
> Yes, fine - but the point being made is that when a single day contains
> 120+ emails, of which well over 70 are part of the same mega-patch, then
> this policy actually does the *opposite* of what is intended --- people
> are simply going to look at the sheer magnitude of that, and exercise
> their ability to delete the entire inbox.
>
> How does _that_ help with the reviewing?  Wouldn't it have been better
> to point to a branch with an email outlining the nature and impact of
> the changes?
>
> Or if we really want to have this in everyone's mailbox, wouldn't it be
> better to break it up over multiple days?
>
> (And yes, I was one who favored the notion of reviewing patches on the
> mailing list -- and I still do -- but I now feel the pain caused by this
> policy when it is taken to the extreme, and I admit that my thinking was
> perhaps naive.)

I agree 70 patches is a bit much, but the principle still holds :) But I 
don't think sending 70 patches will be a daily occurrance, and we now 
that in the future patchsets need to be broken up more, or squashed 
together. It's nice that we can track the typos poky developers made and 
how fast they fixed it, but IMO those patches should be squashed 
together when possible.

regards,

Koen