[oe] [PATCH 0/3] rename packages/ to recipes/ per earlier agreement

Denys Dmytriyenko denis at denix.org
Thu Mar 19 03:13:30 UTC 2009


On Wed, Mar 18, 2009 at 10:01:25PM -0400, Denys Dmytriyenko wrote:
> On Wed, Mar 18, 2009 at 05:25:11PM -0700, Theodore A. Roth wrote:
> > On Tue, Mar 17, 2009 at 12:26 PM, Denys Dmytriyenko <denis at denix.org> wrote:
> > > On Mon, Mar 16, 2009 at 07:56:37PM -0500, Mike (mwester) wrote:
> > >>
> > >> Denys Dmytriyenko wrote:
> > >> > Renaming packages/ directory to recipes/, as one of the several structural
> > >> > changes, was proposed by Koen[1] and agreed/approved by many. Since Koen
> > >> > currently doesn't have time/ability to do the change, and some people are
> > >> > too eager to wait any longer, he asked me to do it. Please ack/nack.
> > >>
> > >> Ack.   But can you please tag the revision immediately preceeding the
> > >> commit of this change so we have some easy-to-reference point[*] in the
> > >> history?
> > >
> > > Done. mv-packages-to-recipes-pre and mv-packages-to-recipes-post are the tags
> > > applied right before and right after the change.
> > >
> > 
> > Is the packages directory supposed to be empty now? There are still a
> > few subdirs left:
> > 
> > 
> > roth at dorkboy:~/dev/OE/openembedded/packages$ ls -1
> > automake/
> > blueprobe/
> > busybox/
> > coreutils/
> > gnome/
> > gpe-gallery/
> > pkgconfig/
> > pyneo/
> > qt4/
> > udev/
> 
> Those are empty directories (unless you have uncommited changes in them). 
> That is because git only keeps track of files, not directories. A simple 
> rename of a single directory resulted in thousands of renames of individual 
> files. When you did "git pull" all the files were moved, leaving the old 
> hierarchy empty. It should be safe to remove by "rm -r packages" - if there 
> are still files there, rm will fail. And if you do a fresh "git clone", there 
> will be no packages/ directory there.

Argh, the above "rm -r packages" is not safe, as it won't fail removing files. 
Please use this command instead:
find packages -depth -type d -empty -exec rmdir {} \;

> > I will generate a patch to the usermanual to note the new recipes
> > directory.
> 
> Thanks for taking care of the documentation.
> 
> > I am curious is the old packages will still be kept around
> > or if it will be completely removed. If kept, how would it be
> > described versus the recipes dir?
> 
> Now recipes/ directory name represents its contents. Packages are normally 
> generated by running/processing recipes. But they are placed inside DEPLOY_DIR 
> and I'm not sure there is any need in packages/ directory in the repository.

-- 
Denys





More information about the Openembedded-devel mailing list