[oe] [oe-commits] Roman I Khimov : (e)glibc-package: fix kernel version passed to qemu

[Phil Blundell]

On Mon, 2009-05-18 at 17:16 +0400, Roman I Khimov wrote:
> On Monday 18 May 2009 16:15:33 Florian Boor wrote:
> > Hi,
> >
> > GIT User account schrieb:
> > > +		kernel_ver = bb.data.getVar("OLDEST_KERNEL", d, 1)
> > > +		if kernel_ver is None:
> > > +			qemu = "qemu-%s  -s 1048576" % target_arch
> > > +		else:
> > > +			qemu = "qemu-%s  -s 1048576 -r %s" % (target_arch, kernel_ver)
> >
> > are you sure this is a good idea?
> > OLDEST_KERNEL defaults to "2.4.0", so this change is likely to break locale
> > generation for every machine that doesn't have OLDEST_KERNEL set.
> 
> I've not heard yet of this really breaking something. And frankly I don't see 
> any reason for that. If it actually does - feel free to shout and scream of 
> course, we'll think how to handle it better.

I guess it'd break on targets where OLDEST_KERNEL isn't set (and hence
defaults to 2.4.0) but you need a kernel newer than 2.4.0 for correct
operation.  Presumably all ARM EABI targets fall into that latter
category, since the TLS syscalls weren't in 2.4.x, and there might be
some others where glibc's default setting for --enable-kernel is
something newer than 2.4.0.

All in all I'd be happier with this change if it enforced a minimum
kernel version of 2.6.16 (i.e. what it used to be) so that there is no
possibility of versions going backwards for any target.

Incidentally, if there is a default value for OLDEST_KERNEL in
bitbake.conf then checking the retrieved value against None seems fairly
futile since that will never be true.

p.