[oe] [PATCH 1/2] udev: fixed obsolete udevadm syntax for udev init.d script.
Tom Rini
trini at embeddedalley.com
Mon May 25 02:06:08 UTC 2009
On Sun, May 24, 2009 at 08:18:10PM +0100, Phil Blundell wrote:
> On Sun, 2009-05-24 at 21:33 +0300, Ihar Hrachyshka wrote:
> > Fixed the following warning message when executing udev init script:
> > "udevadm control commands requires the --<command> format, this will
> > stop working in a future release."
> >
> > Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka at gmail.com>
> > ---
> > recipes/udev/udev-124/init | 4 ++--
> > recipes/udev/udev-141/init | 4 ++--
> > recipes/udev/udev_124.bb | 2 +-
> > recipes/udev/udev_141.bb | 2 +-
> > 4 files changed, 6 insertions(+), 6 deletions(-)
>
> There doesn't seem much point in patching udev 124 for this: that
> version doesn't actually emit the warning as far as I can tell. If the
> initscript is maintained separately for different versions then you
> might as well just patch the -141 version and save a rebuild/reinstall
> for people using 124. Or, alternatively, if the two initscripts are
> actually the same, maybe you could unify them and save on future
> maintenance.
I disagree. There are, I assume, things that could be done on top of
the -141 script as further enchancements/cleanups that would not apply
to -124. But keeping older files in sync, so long as (a) it works and
(b) the older version is cared about makes future buging easier, I've
found.
--
Tom Rini
More information about the Openembedded-devel
mailing list