[oe] [PATCH] busybox: allow building when prefix is "", not "/usr".

Michael Smith msmith at cbnco.com
Wed May 27 01:53:04 UTC 2009


On Tue, 26 May 2009, Phil Blundell wrote:

> Good spotting.  There seems to be more wrong with this code than that,
> though: the comment above says "Move everything to /busybox...", but the
> code (both before and after your change) seems to copy rather than
> moving which would appear to defeat the point of this whole block of
> code.  We had a discussion about this on IRC a few weeks ago but I don't
> think there was any real conclusion to that.

Oh yeah... heh... I guess that copy kind of defeats the purpose. The 
package ends up containing all the symlinks instead of letting 
update-alternatives take care of it in postinst.

I changed the "cp" back to "mv" and the package looks a bit lighter on 
symlinks, and the final rootfs is the same. I'd still want to play a bit 
with upgrades though, and that may be a while. If it looks OK, I'll send 
it up as a separate patch later.

This is where it changed from mv to cp:

commit f7f1ac27e90f042fa1c4322b193b5b6a27cd4c07
Author: Koen Kooi <koen at openembedded.org>
Date:   Sat Aug 26 14:02:37 2006 +0000

    busybox 1.2.1: replace mv with a non-gnu-ish cp


Mike




More information about the Openembedded-devel mailing list