[oe] [PATCH 1/2] tcpdump: fix mix of tabs and spaces in do_configure()
Philip Balister
philip at balister.org
Thu May 28 20:21:02 UTC 2009
Denys Dmytriyenko wrote:
> On Thu, May 28, 2009 at 02:23:32PM -0400, Michael Smith wrote:
>> I randomly picked tabs.
>>
>> Signed-off-by: Michael Smith <msmith at cbnco.com>
>
> I'm not sure this kind of cleanup requires patch review...
It doesn't look like Michael has commit access. I did try applying it,
and git-am said there was a mix of tabs and spaces.
Do we prefer tabs or spaces in bb files?
Philip
>
>> ---
>> recipes/tcpdump/tcpdump_3.9.7.bb | 4 ++--
>> recipes/tcpdump/tcpdump_4.0.0.bb | 6 +++---
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/recipes/tcpdump/tcpdump_3.9.7.bb b/recipes/tcpdump/tcpdump_3.9.7.bb
>> index ba9710d..962663f 100644
>> --- a/recipes/tcpdump/tcpdump_3.9.7.bb
>> +++ b/recipes/tcpdump/tcpdump_3.9.7.bb
>> @@ -15,6 +15,6 @@ EXTRA_OECONF = "--without-crypto"
>> do_configure() {
>> gnu-configize
>> oe_runconf
>> - sed -i 's:/usr/lib:${STAGING_LIBDIR}:' ./Makefile
>> - sed -i 's:/usr/include:${STAGING_INCDIR}:' ./Makefile
>> + sed -i 's:/usr/lib:${STAGING_LIBDIR}:' ./Makefile
>> + sed -i 's:/usr/include:${STAGING_INCDIR}:' ./Makefile
>> }
>> diff --git a/recipes/tcpdump/tcpdump_4.0.0.bb b/recipes/tcpdump/tcpdump_4.0.0.bb
>> index 537cb36..c807fb1 100644
>> --- a/recipes/tcpdump/tcpdump_4.0.0.bb
>> +++ b/recipes/tcpdump/tcpdump_4.0.0.bb
>> @@ -18,8 +18,8 @@ EXTRA_OECONF = "--without-crypto"
>>
>> do_configure() {
>> gnu-configize
>> - autoconf
>> + autoconf
>> oe_runconf
>> - sed -i 's:/usr/lib:${STAGING_LIBDIR}:' ./Makefile
>> - sed -i 's:/usr/include:${STAGING_INCDIR}:' ./Makefile
>> + sed -i 's:/usr/lib:${STAGING_LIBDIR}:' ./Makefile
>> + sed -i 's:/usr/include:${STAGING_INCDIR}:' ./Makefile
>> }
>> --
>> 1.5.6.5
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3303 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20090528/7074893c/attachment-0002.bin>
More information about the Openembedded-devel
mailing list