[oe] [PATCH] gnome.bbclass: remove unneeded scrollkeeper stuff from gnome packages.

[Tom Rini]

On Sun, May 31, 2009 at 12:00:03AM +0300, Ihar Hrachyshka wrote:
> On Sat, May 30, 2009 at 11:53 PM, Tom Rini <trini at embeddedalley.com> wrote:
> > On Mon, May 25, 2009 at 01:17:53PM +0100, Phil Blundell wrote:
> >> On Mon, 2009-05-25 at 14:18 +0300, Ihar Hrachyshka wrote:
> >> > Scrollkeeper generates its XML database for every package when
> >> > installing it. The problem is that while building it sees only specific
> >> > package scrollkeeper stuff so we get wrong scrollkeeper xml file
> >> > generated for every gnome.bbclass package. Including the file into every
> >> > gnome package results in package contents conflicts.
> >> >
> >> > -PACKAGES =+ "${PN}-scrollkeeper-leftovers"
> >> > -FILES_${PN}-scrollkeeper-leftovers = "${localstatedir}/lib/scrollkeeper"
> >> > -
> >> >  gnome_stage_includes() {
> >> >     autotools_stage_includes
> >> >  }
> >> > +
> >> > +do_install_append() {
> >> > +   rm -rf ${D}${localstatedir}/lib/scrollkeeper/*
> >> > +}
> >> > +
> >>
> >> That change looks pretty reasonable to me, though maybe you want to
> >> delete ${localstatedir}/lib/scrollkeeper itself (and its parents, if
> >> they're empty) as well as the contents of the directory.
> >>
> >> In the longer term I guess we should figure out a general-purpose
> >> solution to all this scrollkeeper stuff.  I see that some packages are
> >> configuring themselves --disable-scrollkeeper, others seem to be
> >> patching the scrollkeeper bits out of their configure scripts and yet
> >> others (notably empathy) have, effectively, a local copy of the bits
> >> you've just removed from gnome.bbclass.
> >
> > Do you want more changes still?  I don't see a SOB line, so...  Thanks.
> 
> Should I resend the patch with SOB included?

Your submission was done correctly, sorry.  Asking Phil if he has
anymore requests, or if this is OK to be pushed now.

-- 
Tom Rini