[oe] [PATCH 1/2] tcpdump: fix mix of tabs and spaces in do_configure()

Koen Kooi k.kooi at student.utwente.nl
Sat May 30 21:15:49 UTC 2009


On 30-05-09 21:44, Michael Smith wrote:
> Michael Smith<msmith<at>  cbnco.com>  writes:
>
>> Philip Balister wrote:
>>> It doesn't look like Michael has commit access. I did try applying it,
>>> and git-am said there was a mix of tabs and spaces.
>
>> Yes, the SRC_URI lines were lined up with spaces. It looked nice enough
>> that I didn't fix it;
>
> Hi Philip,
>
> How can I get git am to warn about the mixing? I tried git am
> --whitespace=error-all on the mbox file from patchwork, but it doesn't seem to
> find a mix; actually, in the patch files there are no added lines with spaces,
> only removed lines and a context line.

Ignore git-am "errors" about whitespace. If I add a patch to a recipe 
and do git format-patch in that commit (so you get a patch in a patch) 
git-am will scream bloody murder for something that has no actual 
whitespace errors.
I suspect that the only time you can trust git output is when your name 
is Linus and work on kernel code.

regards,

Koen





More information about the Openembedded-devel mailing list