On Wed, 2009-11-04 at 10:28 -0800, Khem Raj wrote: > there is already a define __USE_BX__ and another macro BX(reg) > I think they should be used here instead No, those macros mean something slightly different. I think the code as written in this patch is correct. p.