[oe] [PATCH] squashfs-4.0: update squashfs-tools to include upstream LZMA inclusion.

Otavio Salvador otavio at ossystems.com.br
Wed Nov 18 13:09:30 UTC 2009


Hello Leon,

On Tue, Nov 17, 2009 at 10:33 PM, Leon Woestenberg
<leon.woestenberg at gmail.com> wrote:
> In OpenEmbedded we used squashfs 4.0 with external patch for LZMA
> compression support. In the meantime, squashfs has mainlined LZMA
> support in its CVS version.
>
> This patches switches to the upstream squashfs-tools and modifies
> bitbake.conf to match the slightly different arguments to mksquashfs.

I agree with the move to mainline version however your recipe changes
might need some improvement. You don't use the lzma recipe available
in OE and instead grab it again ... IMO this is wrong since it
duplicates the lzma source and also make more difficult to us to
"share" fixes.

Besides that  I think it is ok. Can you fix it and send a new patch for review?

Cheers,

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br




More information about the Openembedded-devel mailing list