[oe] Please indicate *why* in the commit messages; commit "kernel.bbclass: force do_deploy call before do_build"

[Martin Jansa]

On Mon, Nov 23, 2009 at 05:35:12PM +0100, Leon Woestenberg wrote:
> Hello Martin,
> 
> especially for changes to core files (such as kernel.bbclass) could
> you indicate in the commit message not only *what* has changed but
> also *why*?
> 
> Your commit message leaves me only guessing for the why:
> 
> kernel.bbclass: force do_deploy call before do_build
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> 
> 
> Thanks!
> 
> Regards,

Sorry, we discussed it with RP and after previous patches of this
bbclass it looked clear to me. But if you look only on this last commit
it is not clear at all.

First do_deploy was called in ${D} dir, where as RP said no stripping
should be allowed.

RP fixed module_strip.bbclass to operate in ${PKGD} directory and fixed
issue that modules in kernel-module-*.ipk files were not stripped at
all.

And also changed kernel.bbclass to create modules.tgz from there, so it 
should contain stripped modules too.

But that task where uImage are coppied to deploy dir was called
before do_package after do_install
which was good for uImage files, but failed to create modules.tgz,
because ${PKGD} dir is not populated in that time.
When I was testing this change i called -c build and because I didn't
see refreshed modules.tgz in my deploy dir i called it twice and it
worked ok (because it was populated already for 2nd run).

After clean rebuild no modules.tgz were created, so I talked to RP again
and he confirmed that we need to call do_deploy AFTER do_package and
that I can remove before parameter and pushed that change, becase RP
said it should be safe.

Then I tried clean rebuild with -c clean -c build and found that
do_deploy wasn't called at all, so I guessed that without before
parameter it can be called somewhere later (before buildall or rm-work
or something) but it wasn't called even without -c argument, so I forced 
it in addtask before do_build, because when -c build finish everything
is in right place so also deploy stuff should be.

Regards,

-- 
uin:136542059                jid:Martin.Jansa at gmail.com
Jansa Martin                 sip:jamasip at voip.wengo.fr 
JaMa