[oe] lighttpd 1.4.18 runtime issue

[Michael Lippautz]

After further investigation, I found a document
(${S}/doc/configuration.txt) that states:
...
  Starting with lighttpd 1.4.0 three default modules are loaded  
  automaticly:

  - mod_indexfile
  - mod_dirlisting
  - mod_staticfile
...

The daemon did not start at all because it failed the module
initialization process. (Got no exact error messages, because I have no
access to the board atm.) The modules cannot be deactivated in the
config. After all, I think an RDEPENDS would be appropriate here. 

git diff (without any formatting changes) is attached.

Regards,
Michael


diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb
b/recipes/lighttpd/lighttpd_1.4.18.bb
index d5870ba..a446122 100644
--- a/recipes/lighttpd/lighttpd_1.4.18.bb
+++ b/recipes/lighttpd/lighttpd_1.4.18.bb
@@ -2,7 +2,12 @@ DESCRIPTION = "Web server"
 SECTION = "net"
 LICENSE = "BSD"
 DEPENDS = "libpcre"
-PR = "r3"
+RDEPENDS_${PN} += " \
+        lighttpd-module-indexfile \
+        lighttpd-module-dirlisting \
+        lighttpd-module-staticfile"
+
+PR = "r4"
 
 SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \
 	   file://configure.in.patch;patch=1 \

Am Montag, den 05.10.2009, 20:27 +0100 schrieb Phil Blundell:
> Thanks for the patch.
> 
> For future reference, please don't combine mechanical operations like
> reformatting with other edits in a single patch.  It makes it much
> harder to see what the patch is actually doing if there is a lot of
> other extraneous noise going on.
> 
> Can you clarify what the effect is of failing to install
> lighttpd-module-indexfile; does the daemon just refuse to start at all,
> or does it just ignore the config file directive if the module is
> missing?  If the latter, and/or if folks are likely to edit the config
> file to remove the reference to that module, it might be better to set
> the module package as RRECOMMENDS rather than RDEPENDS.
> 
> p.
> 
> On Mon, 2009-10-05 at 20:52 +0200, Michael Lippautz wrote:
> > hej,
> > 
> > lighttpd_1.4.18 is installed with a config that should actually load its
> > module mod-indexfile.so.
> > 
> > Since the config is pretty default, I added the module to the runtime
> > depends. (also re-formated recipe, uses tabs now).
> > 
> > Regards,
> > Michael
> > 
> > 
> > diff --git a/recipes/lighttpd/lighttpd_1.4.18.bb
> > b/recipes/lighttpd/lighttpd_1.4.18.bb
> > index d5870ba..80d22bc 100644
> > --- a/recipes/lighttpd/lighttpd_1.4.18.bb
> > +++ b/recipes/lighttpd/lighttpd_1.4.18.bb
> > @@ -2,26 +2,31 @@ DESCRIPTION = "Web server"
> >  SECTION = "net"
> >  LICENSE = "BSD"
> >  DEPENDS = "libpcre"
> > -PR = "r3"
> > -
> > -SRC_URI = "http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \
> > -	   file://configure.in.patch;patch=1 \
> > -	   file://mod_redirect.c.patch;patch=1 \
> > -	   file://src-server.c.patch;patch=1 \
> > -	   file://index.html \
> > -	   file://lighttpd.conf \
> > -	   file://lighttpd"
> > -
> > -EXTRA_OECONF="--without-bzip2 \
> > -		--without-ldap \
> > -		--without-lua \
> > -		--without-memcache \
> > -		--with-pcre \
> > -		--without-webdav-props \
> > -		--without-webdav-locks \
> > -		--without-openssl \
> > -		--disable-nls \
> > -		--disable-static"
> > +PR = "r4"
> > +
> > +RDEPENDS_${PN} += " \
> > +	lighttpd-module-indexfile"
> > +
> > +SRC_URI = " \
> > +	http://www.lighttpd.net/download/lighttpd-${PV}.tar.gz \
> > +	file://configure.in.patch;patch=1 \
> > +	file://mod_redirect.c.patch;patch=1 \
> > +	file://src-server.c.patch;patch=1 \
> > +	file://index.html \
> > +	file://lighttpd.conf \
> > +	file://lighttpd"
> > +
> > +EXTRA_OECONF=" \
> > +	--without-bzip2 \
> > +	--without-ldap \
> > +	--without-lua \
> > +	--without-memcache \
> > +	--with-pcre \
> > +	--without-webdav-props \
> > +	--without-webdav-locks \
> > +	--without-openssl \
> > +	--disable-nls \
> > +	--disable-static"
> >  
> >  inherit autotools pkgconfig update-rc.d
> >  
> > @@ -44,6 +49,6 @@ FILES_${PN} += "${sysconfdir} /www"
> >  PACKAGES_DYNAMIC = "lighttpd-module-*"
> >  
> >  python populate_packages_prepend () {
> > -        lighttpd_libdir = bb.data.expand('${libdir}', d)
> > -        do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$',
> > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='')
> > +	lighttpd_libdir = bb.data.expand('${libdir}', d)
> > +	do_split_packages(d, lighttpd_libdir, '^mod_(.*)\.so$',
> > 'lighttpd-module-%s', 'Lighttpd module for %s', extra_depends='')
> >  }
> > 
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel