[oe] [PATCH] armv5te mentioned twice on eabi-capable list

Koen Kooi k.kooi at student.utwente.nl
Wed Sep 16 18:17:48 UTC 2009


On 16-09-09 14:48, Cliff Brake wrote:
> On Wed, Sep 16, 2009 at 6:19 AM, Aleksandr Koltsoff<czr at iki.fi>  wrote:
>> (My first patch generated with git, please be gentle :-).
>>
>> armv5te is mentioned twice in the arm_eabi_supporting_arches list of
>> sane-toolchain.inc. Remove the latter occurance.
>
> Looks good.  I'll let Khem or some who is more familiar with toolchains apply.
>
> One suggestion, we have a commit policy
> (http://wiki.openembedded.net/index.php/Commit_Policy), so if you
> follow that on future patches, we can directly git-am your patches and
> push them with no extra work.
>
> So the commit message for this might be:
>
> sane-toolchain.inc: remove extra armv5te in eabi-capable list
>
> This allows people to very quickly get an idea what this patch applies
> to, and makes for nice formatting in the weekly change logs.

Note that in general we don't like putting the filename in the commit 
message.

regards,

Koen





More information about the Openembedded-devel mailing list