[oe] a38e7ff2810e55455c7ff7b01d4882344b420e18 breaks build and packaged-staging, among other things

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Looking at
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=a38e7ff2810e55455c7ff7b01d4882344b420e18
I see:

- -do_stage_append() {
+vala_do_stage_vapi() {
 	install -d ${STAGING_DATADIR_NATIVE}/vala/vapi
 	for VALAFILE in `find . -name "*.vapi" | grep -v
"$VALA_DONT_STAGE_VAPIS"`; do install -m 0644 ${VALAFILE}
${STAGING_DATADIR_NATIVE}/vala/vapi/; done
 	for VALAFILE in `find . -name "*.deps" | grep -v
"$VALA_DONT_STAGE_VAPIS"`; do install -m 0644 ${VALAFILE}
${STAGING_DATADIR_NATIVE}/vala/vapi/; done
 }
+
+EXPORT_FUNCTIONS do_stage_vapi
+
+addtask stage_vapi after do_populate_staging before do_package

Attentive readers will see that anything using vala.bbclass will now
stage things needed for downstream dependencies outside of do_stage
*and* do_install()

This means that doing

bitbake something-depending-on-vala-stuf

is now broken because bitbake will run
something-depending-on-vala-stuf.do_configure and compile after
vala-stuff.do_populate_staging and the vapi files will NOT be there.

The other problem is that the packaged-staging packages won't contain
the vapi files, so rebuilding staging it broken as well.

So all in all: please revert that.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFL1JowMkyGM64RGpERAnRZAJ4qt9DIkXen+f8KTqp9yWE7YZfibQCdHUAo
mS3KolPmIvCmOv1F4GHzPS4=
=UAn/
-----END PGP SIGNATURE-----