[oe] [PATCH] 500+ recipes: remove do_stage

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Wed Aug 4 05:47:10 UTC 2010


2010/8/4 Denys Dmytriyenko <denis at denix.org>

>
> >
> > First collateral damage - libxcb was broken, due to xcb-proto.inc having
> > do_stage(). Worked with Khem to find the cause and thanks for pushing the
> fix:
> >
> >
> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=b0061845a60d7781f9287ae6955585485f5ba8e9
>
> BTW, just wanted to mention - if corresponding PRs had been bumped, it
> would
> have been spotted sooner and not only by people with clean TMPDIR... :)
>

Thanks for noticing and fixing.
Actually to some extend xcb was at fault. Having both the recipe and the
.inc file define a do_stage is no good I'd say (and it would be nice if the
tools would capture this and emit at least a warning, but preferably an
error).

Wrt the PR bump, it was my understanding that the cross patches from Khem
would require cleaning of tmp anyway. It was requested (in the cross patches
thread) to apply this before the cross patch so we would be on a clean slate
anyway.
(and yeah, the patch was generated automatically, and manually adding some
500+ recipes to bump PR is somewhat labourous).

Anyway, apologies for the inconvenience. Hope this is the only recipe
causing an issue.

Frans.



More information about the Openembedded-devel mailing list