[oe] [PATCH] 500+ recipes: remove do_stage
Frans Meulenbroeks
fransmeulenbroeks at gmail.com
Wed Aug 4 05:54:13 UTC 2010
2010/8/4 Khem Raj <raj.khem at gmail.com>
>
> > I dont think this has been pushed yet. I have it staged in my tree though
> > I am building from scratch lets see.
>
> oh indeed it is pushed. Well well. We should have got rid of inherit
> autotools_stage in mass as well but I have a patch for that.
>
> After gettting two acks and in view of the PR thing, Koen pushed it
yesterday afternoon (his and my TZ).
Wrt your remark about getting rid of autotools_stage in mass and having a
patch:
Can you submit the patch for review so we do not duplicate work
And while we're at it:
Should code like this:
do_install () {
autotools_do_install
install -d ${D}${base_bindir}
mv ${D}${bindir}/grep ${D}${base_bindir}/grep.${PN}
mv ${D}${bindir}/egrep ${D}${base_bindir}/egrep.${PN}
mv ${D}${bindir}/fgrep ${D}${base_bindir}/fgrep.${PN}
}
be changed into:
do_install_append () {
install -d ${D}${base_bindir}
mv ${D}${bindir}/grep ${D}${base_bindir}/grep.${PN}
mv ${D}${bindir}/egrep ${D}${base_bindir}/egrep.${PN}
mv ${D}${bindir}/fgrep ${D}${base_bindir}/fgrep.${PN}
}
of course something similar could be done for other autotools_* things like
this one:
do_configure () {
autotools_do_configure
cd ${S}
# prevent libtool from linking libs against libstdc++, libgcc, ...
cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/'
> ${TARGET_PREFIX}libtool.tmp
mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
}
Best regards, Frans.
More information about the Openembedded-devel
mailing list